Skip to content

Commit 9277c0e

Browse files
committed
Experiment with faster project loading
1 parent 1ac6000 commit 9277c0e

File tree

4 files changed

+4
-6
lines changed

4 files changed

+4
-6
lines changed

lib/code_corps_web/controllers/project_controller.ex

+1-1
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ defmodule CodeCorpsWeb.ProjectController do
4646

4747
@preloads [
4848
:donation_goals, [organization: [:organization_github_app_installations, :projects, :slugged_route, :stripe_connect_account]],
49-
:project_categories, :project_github_repos, :project_skills,
49+
:project_categories, :project_github_repos, [project_skills: :skill],
5050
[project_users: :user], :stripe_connect_plan, :task_lists, :tasks
5151
]
5252

lib/code_corps_web/views/project_skill_view.ex

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,5 @@ defmodule CodeCorpsWeb.ProjectSkillView do
44
use JaSerializer.PhoenixView
55

66
has_one :project, type: "project", field: :project_id
7-
has_one :skill, type: "skill", field: :skill_id
7+
has_one :skill, serializer: CodeCorpsWeb.SkillView, include: true
88
end

lib/code_corps_web/views/project_view.ex

+2-2
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@ defmodule CodeCorpsWeb.ProjectView do
1818
has_one :stripe_connect_plan, serializer: CodeCorpsWeb.StripeConnectPlanView
1919

2020
has_many :donation_goals, serializer: CodeCorpsWeb.DonationGoalView, identifiers: :always
21-
has_many :project_categories, serializer: CodeCorpsWeb.ProjectCategoryView, identifiers: :always
21+
has_many :project_categories, serializer: CodeCorpsWeb.ProjectCategoryView, include: true
2222
has_many :project_github_repos, serializer: CodeCorpsWeb.ProjectGithubRepoView, identifiers: :always
23-
has_many :project_skills, serializer: CodeCorpsWeb.ProjectSkillView, identifiers: :always
23+
has_many :project_skills, serializer: CodeCorpsWeb.ProjectSkillView, include: true
2424
has_many :project_users, serializer: CodeCorpsWeb.ProjectUserView, include: true
2525
has_many :tasks, serializer: CodeCorpsWeb.TaskView, identifiers: :always
2626
has_many :task_lists, serializer: CodeCorpsWeb.TaskListView, identifiers: :always

lib/code_corps_web/views/skill_view.ex

-2
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,4 @@ defmodule CodeCorpsWeb.SkillView do
44
use JaSerializer.PhoenixView
55

66
attributes [:title, :description, :inserted_at, :updated_at]
7-
8-
has_many :role_skills, serializer: CodeCorpsWeb.RoleSkillView, identifiers: :always
97
end

0 commit comments

Comments
 (0)