Update test cases for #zm7 alternation #34

andy1li · 2025-06-05T21:22:52Z

Context:

It's kinda hard to come up with an negative compound test case that's interesting, so how about two positive ones?

Since it's the last main stage, hopefully it's not too crazy.

coderabbitai · 2025-06-05T21:22:58Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

internal/stage_alternation.go

rohitpaulk

Let's simplify @andy1li - notes added

…ching

rohitpaulk · 2025-06-06T20:41:01Z

internal/stage_alternation.go

 		{
 			Pattern:          "a (cat|dog)",
 			Input:            "a cow",
 			ExpectedExitCode: 1,
 		},
+		{
+			Pattern:          "^((Buffalo|buffalo)[ ]?)+$",
+			Input:            "Buffalo buffalo buffalo Buffalo buffalo",


Still seems super arcane @andy1li - I saw the link you shared and now remember it, but what we're looking for is something that a user is going to be happy to debug and figure out. If it seems like something that isn't "obvious" or something that they might not use in the real-world this is going to be frustrating for them.

I'll give you one example to get started (don't have to use this one, just to illustrate and I'm also not sure if all features used here are covered in previous stages):

I see 1 cat, 2 dogs and 3 cows ^I see (\d (cat|dog|apple)s?(, | and )?)+

Makes sense!

Yep, all features are covered. (We just cannot use sentence-ending punctuations like . or ?, because we didn't introduce escaping.)

rohitpaulk

Added note

…ounting animals

internal/stage_alternation.go

rohitpaulk

Note added

…just expected exit codes

andy1li · 2025-06-09T20:31:25Z

Thanks @cjon256 for the suggestion!

andy1li added 2 commits June 6, 2025 05:16

Add new test cases for complex patterns in stage alternation

059f7b2

Add new test cases for complex patterns in stage backreferences

55145d1

andy1li requested a review from rohitpaulk June 5, 2025 21:24

Update regex patterns in test cases for 'will' to be case-insensitive

59dd45f

rohitpaulk reviewed Jun 6, 2025

View reviewed changes

internal/stage_alternation.go Outdated Show resolved Hide resolved

rohitpaulk requested changes Jun 6, 2025

View reviewed changes

Update test cases to use a simplified input for 'Buffalo' pattern mat…

02e4880

…ching

andy1li requested a review from rohitpaulk June 6, 2025 20:16

rohitpaulk reviewed Jun 6, 2025

View reviewed changes

rohitpaulk requested changes Jun 6, 2025

View reviewed changes

Update test cases to replace 'Buffalo' pattern with a new regex for c…

83fb413

…ounting animals

andy1li force-pushed the andy/tweak branch from 82a6368 to 83fb413 Compare June 6, 2025 21:02

Update test cases to replace 'Buffalo' pattern with a new regex for c…

364abe4

…ounting animals

andy1li self-assigned this Jun 6, 2025

andy1li requested a review from rohitpaulk June 6, 2025 21:05

rohitpaulk reviewed Jun 6, 2025

View reviewed changes

internal/stage_alternation.go Outdated Show resolved Hide resolved

rohitpaulk requested changes Jun 6, 2025

View reviewed changes

Update test cases to modify regex patterns for animal counting and ad…

f0b0d3a

…just expected exit codes

andy1li requested a review from rohitpaulk June 6, 2025 21:11

rohitpaulk approved these changes Jun 6, 2025

View reviewed changes

andy1li merged commit 4743bcf into main Jun 9, 2025
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update test cases for #zm7 alternation #34

Update test cases for #zm7 alternation #34

Uh oh!

andy1li commented Jun 5, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Jun 5, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Uh oh!

rohitpaulk left a comment

Uh oh!

rohitpaulk Jun 6, 2025 •

edited

Loading

Uh oh!

andy1li Jun 6, 2025 •

edited

Loading

Uh oh!

rohitpaulk left a comment

Uh oh!

Uh oh!

rohitpaulk left a comment

Uh oh!

Uh oh!

andy1li commented Jun 9, 2025

Uh oh!

Uh oh!

Update test cases for #zm7 alternation #34

Update test cases for #zm7 alternation #34

Uh oh!

Conversation

andy1li commented Jun 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Jun 5, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Uh oh!

rohitpaulk left a comment

Choose a reason for hiding this comment

Uh oh!

rohitpaulk Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

andy1li Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rohitpaulk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rohitpaulk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

andy1li commented Jun 9, 2025

Uh oh!

Uh oh!

andy1li commented Jun 5, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

rohitpaulk Jun 6, 2025 •

edited

Loading

andy1li Jun 6, 2025 •

edited

Loading