-
Notifications
You must be signed in to change notification settings - Fork 46
fix(cli): update vitest, fix coverage command and unmet peer #1483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(cli): update vitest, fix coverage command and unmet peer #1483
Conversation
@spirulence is attempting to deploy a commit to the Codemod Team on Vercel. A member of the Team first needs to authorize it. |
f592e61
to
cc206f9
Compare
commit: |
cc206f9
to
47d480e
Compare
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
@spirulence I'm unable to build
Are you able to reproduce this? |
I was not. Let me check. |
@mohab-sameh Unfortunately I am not able to replicate this, either in the Ubuntu 24 environment I use in normal development or on my MacBook. Turbo build commands run to success on both. I may still be able to help identify the issue. Can you share more details about what platform you're developing on, including Node version, npm version, pnpm version, Turbo version, operating system, processor architecture, and the error you receive when you do not include the file loader for .node executables in the The two platforms I double-checked:
Please forgive any of the following details that you already know. I include a lot of context so that our discussion on this issue may be a helpful artifact to your team in the future for any similar issues involving packaged binaries and local build processes. There are at least a couple of ways we can resolve this. 1) Change build configurationThe first would be to figure out if your fix for the The filetype you've had to handle specifically is usually from an artifact being packaged as a native executable, either in an external dependency or one from inside the workspace. The error you receive may be able to help identify which In my experience, the presence of these native binaries can be platform dependent. Projects may change the type of their packaged artifact per platform, especially if they attempt to target Windows in addition to Alpine (musl) and Debian/RHEL linux (libc), not to mention different ways of supporting If the error message you receive is insufficient to find the specific dependency or dependencies causing the issues, it may be helpful to use a find . -name "*.node"
./node_modules/.pnpm/@ast-grep+napi-linux-x64-gnu@0.25.4/node_modules/@ast-grep/napi-linux-x64-gnu/ast-grep-napi.linux-x64-gnu.node
./node_modules/.pnpm/@rollup+rollup-linux-x64-musl@4.34.4/node_modules/@rollup/rollup-linux-x64-musl/rollup.linux-x64-musl.node
./node_modules/.pnpm/@rollup+rollup-linux-x64-gnu@4.34.4/node_modules/@rollup/rollup-linux-x64-gnu/rollup.linux-x64-gnu.node
./node_modules/.pnpm/@next+swc-linux-x64-gnu@14.2.4/node_modules/@next/swc-linux-x64-gnu/next-swc.linux-x64-gnu.node
./node_modules/.pnpm/@next+swc-linux-x64-musl@14.2.4/node_modules/@next/swc-linux-x64-musl/next-swc.linux-x64-musl.node
./node_modules/.pnpm/@msgpackr-extract+msgpackr-extract-linux-x64@3.0.3/node_modules/@msgpackr-extract/msgpackr-extract-linux-x64/node.napi.musl.node
./node_modules/.pnpm/@msgpackr-extract+msgpackr-extract-linux-x64@3.0.3/node_modules/@msgpackr-extract/msgpackr-extract-linux-x64/node.napi.glibc.node
./node_modules/.pnpm/@msgpackr-extract+msgpackr-extract-linux-x64@3.0.3/node_modules/@msgpackr-extract/msgpackr-extract-linux-x64/node.abi115.musl.node
./node_modules/.pnpm/@msgpackr-extract+msgpackr-extract-linux-x64@3.0.3/node_modules/@msgpackr-extract/msgpackr-extract-linux-x64/node.abi115.glibc.node
./node_modules/.pnpm/@prisma+engines@5.15.1/node_modules/@prisma/engines/libquery_engine-debian-openssl-3.0.x.so.node
./node_modules/.pnpm/keytar@7.9.0/node_modules/keytar/build/Release/keytar.node
./node_modules/.pnpm/@ast-grep+napi-linux-x64-musl@0.25.4/node_modules/@ast-grep/napi-linux-x64-musl/ast-grep-napi.linux-x64-musl.node
./node_modules/.pnpm/prisma@5.15.1/node_modules/prisma/libquery_engine-debian-openssl-3.0.x.so.node My money is on a .node file, used in vitest coverage, that is missing without the special handling you've added. This would be one area, tracing and profiling, where different platforms have very different approaches to instrumentation. This would be easily differentiated by seeing if 2) Different reproduction scriptIt is highly likely that the way I'm running these unit tests is not standard. I did only a rudimentary search of the repo to try and find the standard way that developers are running these unit tests during development and didn't come up with anything. When I attempted to run So I lifted these commands from the way that they are invoked in CI. See codemod/.github/workflows/test.yml Line 53 in e8d1ca3
Please check if YOU GUYS ARE THE BEST |
📚 Description
Coverage report generation for the cli is failing with a TypeError. Fix is to update the
vitest
version to match the coverage provider version installed in the catalog.In addition, fixes an unmet peer warning in the cli application due to the coverage provider package wanting the updated version of
vitest
installed.🔗 Linked Issue
🧪 Test Plan
Use the following reproduction script:
📄 Documentation to Update