Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analyzer merge should not take previously created result file into account. #6

Closed
woolfg opened this issue Mar 11, 2021 · 3 comments
Closed
Labels
bug Something isn't working

Comments

@woolfg
Copy link

woolfg commented Mar 11, 2021

if you run the anlyzer twice the previous result file codeprints_merged.json is merged again. The total count is increased with every execution.

    Finished dev [unoptimized + debuginfo] target(s) in 0.04s
     Running `target/debug/codeprints-analyzer merge`
Merging codeprints_analyzer.json
Merging codeprints_github.json
Merging codeprints_merged.json
done!
Output file: codeprints_merged.json

Expected: the process is deterministic and the result file is ignored.

@mre
Copy link
Contributor

mre commented Mar 11, 2021

lol

@mre mre added the bug Something isn't working label Mar 11, 2021
@mre
Copy link
Contributor

mre commented Mar 11, 2021

We could call the output file merged_codeprints.json or something so that the glob doesn't match.

for entry in glob("codeprints*.json")? {

@mre
Copy link
Contributor

mre commented Mar 18, 2021

This should be fixed now in #4.

@mre mre closed this as completed Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants