Skip to content

Commit b58bfeb

Browse files
authored
fix: disable UDP connections on windows-rdp module (#149)
## Description Relates to Fixes an issue where RDP doesn't function properly over Coder Connect, by disabling UDP and relying only on TCP. c.f. coder/internal#608 (comment) for a detailed description of the problem. --- ## Type of Change - [ ] New module - [X] Bug fix - [ ] Feature/enhancement - [ ] Documentation - [ ] Other --- ## Module Information <!-- Delete this section if not applicable --> **Path:** `registry/coder/modules/windows-rdp` **New version:** `v1.0.19` **Breaking change:** [ ] Yes [x] No --- ## Testing & Validation - [x] Tests pass (`bun test`) - [x] Code formatted (`bun run fmt`) - [x] Changes tested locally --- ## Related Issues coder/internal#608 Closes # --------- Signed-off-by: Spike Curtis <spike@coder.com>
1 parent 0512430 commit b58bfeb

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

registry/coder/modules/windows-rdp/README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ Enable Remote Desktop + a web based client on Windows workspaces, powered by [de
1616
module "windows_rdp" {
1717
count = data.coder_workspace.me.start_count
1818
source = "registry.coder.com/coder/windows-rdp/coder"
19-
version = "1.2.0"
19+
version = "1.2.1"
2020
agent_id = resource.coder_agent.main.id
2121
resource_id = resource.aws_instance.dev.id
2222
}
@@ -34,7 +34,7 @@ module "windows_rdp" {
3434
module "windows_rdp" {
3535
count = data.coder_workspace.me.start_count
3636
source = "registry.coder.com/coder/windows-rdp/coder"
37-
version = "1.2.0"
37+
version = "1.2.1"
3838
agent_id = resource.coder_agent.main.id
3939
resource_id = resource.aws_instance.dev.id
4040
}
@@ -46,7 +46,7 @@ module "windows_rdp" {
4646
module "windows_rdp" {
4747
count = data.coder_workspace.me.start_count
4848
source = "registry.coder.com/coder/windows-rdp/coder"
49-
version = "1.2.0"
49+
version = "1.2.1"
5050
agent_id = resource.coder_agent.main.id
5151
resource_id = resource.google_compute_instance.dev[0].id
5252
}
@@ -58,7 +58,7 @@ module "windows_rdp" {
5858
module "windows_rdp" {
5959
count = data.coder_workspace.me.start_count
6060
source = "registry.coder.com/coder/windows-rdp/coder"
61-
version = "1.2.0"
61+
version = "1.2.1"
6262
agent_id = resource.coder_agent.main.id
6363
resource_id = resource.aws_instance.dev.id
6464
devolutions_gateway_version = "2025.1.6" # Specify a specific version

registry/coder/modules/windows-rdp/powershell-installation-script.tftpl

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,11 @@ function Configure-RDP {
1616
New-ItemProperty -Path 'HKLM:\System\CurrentControlSet\Control\Terminal Server\WinStations\RDP-Tcp' -Name "SecurityLayer" -Value 1 -PropertyType DWORD -Force
1717
# Enable RDP through Windows Firewall
1818
Enable-NetFirewallRule -DisplayGroup "Remote Desktop"
19+
20+
# Disable UDP. It doesn't work via `coder port-forward` and is broken due to MTU issues in Coder Connect.
21+
# Requires a restart to take effect. c.f. https://github.com/coder/internal/issues/608#issuecomment-2965923672
22+
New-ItemProperty -Path 'HKLM:\SOFTWARE\Policies\Microsoft\Windows NT\Terminal Services' -Name "SelectTransport" -Value 1 -PropertyType DWORD -Force
23+
Restart-Service -Name "TermService" -Force
1924
}
2025

2126
function Install-DevolutionsGateway {

0 commit comments

Comments
 (0)