OPIK-1036: Updated backend dependencies part 3 #1307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagohora
reviewed
Feb 17, 2025
Comment on lines
+83
to
+85
| <dependency> | ||
| <groupId>org.apache.httpcomponents.core5</groupId> | ||
| <artifactId>httpcore5</artifactId> | ||
| <version>5.3.3</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>net.minidev</groupId> | ||
| <artifactId>json-smart</artifactId> | ||
| <version>2.5.2</version> | ||
| </dependency> |
There was a problem hiding this comment.
Those are not bom dependencies
There was a problem hiding this comment.
That's intended:
- Those libraries don't have BOMs available and probably don't need them.
- They're transitive dependencies, not direct ones, so they shouldn't be defined in
dependenciessection. - We should force a minor version upgrade by defining them in
dependencyManagementas they're transitive only.
andrescrz
force-pushed
the
andrescrz/OPIK-1036-upgrade-backend-dependencies-part-3
branch
from
5c2ecf6 to
940d84f
Compare
thiagohora
approved these changes
Feb 17, 2025
andrescrz
deleted the
andrescrz/OPIK-1036-upgrade-backend-dependencies-part-3
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Upgraded only transitive dependencies:
nettywith a BOM.json-smart.Regarding
httpcore5as it's also a transitive dependency, it was wrongly defined adependencyin a previous PR #1299. It's not an actual direct dependency, so moved todependencyManagementwhich is the correct place.Issues
OPIK-1036
Testing
Documentation