-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OPIK-1005] OpenTelemetry Traces ingestion endpoint #1309
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagohora
reviewed
Feb 18, 2025
apps/opik-backend/src/main/java/com/comet/opik/api/resources/v1/priv/OpenTelemetryResource.java
Show resolved
Hide resolved
thiagohora
reviewed
Feb 18, 2025
apps/opik-backend/src/main/java/com/comet/opik/domain/OpenTelemetryService.java
Outdated
Show resolved
Hide resolved
thiagohora
reviewed
Feb 18, 2025
apps/opik-backend/src/main/java/com/comet/opik/domain/OpenTelemetryService.java
Outdated
Show resolved
Hide resolved
thiagohora
reviewed
Feb 18, 2025
apps/opik-backend/src/main/java/com/comet/opik/utils/OpenTelemetryUtils.java
Outdated
Show resolved
Hide resolved
thiagohora
reviewed
Feb 18, 2025
apps/opik-backend/src/main/java/com/comet/opik/utils/OpenTelemetryUtils.java
Outdated
Show resolved
Hide resolved
thiagohora
reviewed
Feb 18, 2025
apps/opik-backend/src/main/java/com/comet/opik/utils/OpenTelemetryUtils.java
Outdated
Show resolved
Hide resolved
idoberko2
reviewed
Feb 18, 2025
apps/opik-backend/src/main/java/com/comet/opik/domain/OpenTelemetryService.java
Outdated
Show resolved
Hide resolved
idoberko2
reviewed
Feb 18, 2025
apps/opik-backend/src/main/java/com/comet/opik/utils/OpenTelemetryUtils.java
Outdated
Show resolved
Hide resolved
@ldaugusto I tested the endpoint locally with smolagents and it is working good, good job! |
thiagohora
reviewed
Feb 18, 2025
apps/opik-backend/src/main/java/com/comet/opik/domain/OpenTelemetryService.java
Outdated
Show resolved
Hide resolved
thiagohora
reviewed
Feb 18, 2025
apps/opik-backend/src/main/java/com/comet/opik/domain/OpenTelemetryService.java
Outdated
Show resolved
Hide resolved
thiagohora
reviewed
Feb 18, 2025
apps/opik-backend/src/main/java/com/comet/opik/domain/OpenTelemetryService.java
Outdated
Show resolved
Hide resolved
thiagohora
approved these changes
Feb 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Creates a new ingestion way for Opik, using OpenTelemetry API (for now, just /traces). This way libraries like pydantic.ai and smolagent can send spans to Opik by setting some environmental variables like
(for local)
(for cloud environments)
Unlike Opik, OpenTelemetry (otel) has no concept of a formal Trace: their trace_id is only a single column that all spans have in common for a single fetch operation. To make it opik-able, we're cloning the root span into a (opik) Trace, very much like python sdk. The whole span payload for now is inserted as 'input' as the parsing is library-dependable. We will bit a parser mapping in a future PR.
The ids where a problem, as otel uses 128-bit random ints for trace_id and 64-bit random ints for span_id. The batchs are sent out of order: the root span is sent last (as it needs and 'end_time'), so we can't tell what's going to be the UUIDv7 for the trace by the first batch, so we truncate span time by the day as a 'prediction' for what the opik trace id would be.
In a future PR we will look for a better way to translate otel ids into opik ids.
Issues
Resolves #
Testing
Documentation