messaging: cleanup zero-frequency service initialization

[jyoung8607]

Fix a bug wherein zero-frequency (on-demand only) services wouldn't go alive in the simulator without having seen at least one message, and make their initial state valid.

[TheSecurityDev]

To make #34920 (and other zero-frequency services) work, you need to change:

openpilot/cereal/messaging/__init__.py

Line 181 in d3ebe09

self.valid[s] = False

To:

self.valid[s] = SERVICE_LIST[s].frequency <= 1e-5 # Default to valid for zero frequency services

[jyoung8607]

Did some more cleanup. @TheSecurityDev, if you can verify this works for you in the sim, I'll merge it.

[TheSecurityDev]

Did some more cleanup. @TheSecurityDev, if you can verify this works for you in the sim, I'll merge it.

Unfortunately it doesn't work, but with a different issue:

Failed to retrieve initial values: Car model mismatch
logcatd proclogd modeld ui soundd locationd calibrationd torqued controlsd selfdrived card deleter paramsd lagd plannerd radard hardwared statsd
Failed to retrieve initial lag: Car model mismatch
{"event": "selfdrived.initialized", "dt": 0.0, "timeout": false, "canValid": true, "invalid": ["pandaStates", "modelV2", "liveCalibration", "carOutput", "longitudinalPlan", "livePose", "liveDelay", "liveParameters", "radarState", "liveTorqueParameters", "controlsState", "carControl", "driverAssistance", "alertDebug", "driverCameraState", "wideRoadCameraState", "gpsLocation"], "not_alive": ["pandaStates", "modelV2", "liveCalibration", "longitudinalPlan", "livePose", "liveDelay", "liveParameters", "radarState", "liveTorqueParameters", "driverAssistance", "alertDebug", "driverCameraState", "wideRoadCameraState", "gpsLocation"], "not_freq_ok": [], "error": true}

I don't understand why the simulator test didn't catch that though.

Update: It seems to be working now, not sure what happened there.

[TheSecurityDev]

Did some more cleanup. @TheSecurityDev, if you can verify this works for you in the sim, I'll merge it.

Hmmm, okay nevermind, it seems to be working now. I'm not sure what happened there.

Fixed a different way