Skip to content

feat(clip): font from selfdrive/assets #35194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 13, 2025
Merged

feat(clip): font from selfdrive/assets #35194

merged 5 commits into from
May 13, 2025

Conversation

greatgitsby
Copy link
Contributor

@greatgitsby greatgitsby commented May 12, 2025 •
edited
Loading

use font from selfdrive/assets

using Inter-Regular the metadata padding changed. changing to 15 makes box align with border again

fonts-inter is no longer needed

@github-actions github-actions bot added the tools label May 12, 2025
@greatgitsby greatgitsby marked this pull request as ready for review May 12, 2025 23:17
sshane
sshane reviewed May 13, 2025
View reviewed changes
@greatgitsby greatgitsby marked this pull request as draft May 13, 2025 00:59
@greatgitsby
Copy link
Contributor Author

we store font files in selfdrive/assets, let's just use these instead. will remove most of this extra validation

@greatgitsby greatgitsby changed the title feat(clip): find font dynamically feat(clip): font from selfdrive/assets May 13, 2025
@greatgitsby greatgitsby marked this pull request as ready for review May 13, 2025 01:41
@adeebshihadeh adeebshihadeh merged commit 6b4436b into commaai:master May 13, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sshane sshane sshane left review comments

Assignees
No one assigned
Labels
tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@greatgitsby @sshane @adeebshihadeh