Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi arch matrix pipeline #341

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Multi arch matrix pipeline #341

merged 2 commits into from
Jun 20, 2024

Conversation

alcohol
Copy link
Member

@alcohol alcohol commented Jun 14, 2024

  • setup multi arch pipeline for
    • current
    • lts
    • previous versions (or just remove these?)
    • v1 (or just remove?)

@alcohol
Copy link
Member Author

alcohol commented Jun 15, 2024

@tianon @crazy-max I hope I am not imposing here; I am trying to wrap my head around setting up multi-arch builds for our non-official images. I have looked at various documentation sources and your repository which was also referenced somewhere as an example. But I am not sure I am getting it.. any pointers on where I might be overlooking something would be greatly appreciated. Right now I managed to get the digests pushed, and the manifest merged, but labels (or annotations for multi-arch ?) seem to be missing still. I am also seeing an unknown/unknown arch when I look at the tagged versions over at https://github.com/composer/docker/pkgs/container/docker/ which I cannot figure out where it is coming from.

There is also the minor added complexity of having to have builds based on tags/source from another repository (composer/composer) using:

  • multiple directories / workflows;
  • multiple container repositories to push to;
  • two different build outputs (based on target).

Sources I have referenced:

The following also does not look right..

$ docker run --rm mplatform/mquery composer/composer:lts
Unable to find image 'mplatform/mquery:latest' locally
latest: Pulling from mplatform/mquery
f7727aa0d57a: Pull complete
2db63f065e4b: Pull complete
Digest: sha256:d0989420b6f0d2b929fd9355f15c767f62d0e9a72cdf999d1eb16e6073782c71
Status: Downloaded newer image for mplatform/mquery:latest
Image: composer/composer:lts (digest: sha256:e951c2fee044548fa9a846f1e1a2de4adb53155cfba21290dae5cedb462ba071)
 * Manifest List: Yes (Image type: application/vnd.oci.image.index.v1+json)
 * Supported platforms:
   - linux/s390x
   - unknown/unknown
   - linux/arm/v6
   - unknown/unknown
   - linux/riscv64
   - unknown/unknown
   - linux/386
   - unknown/unknown
   - linux/amd64
   - unknown/unknown
   - linux/ppc64le
   - unknown/unknown
   - linux/arm/v7
   - unknown/unknown
   - linux/arm/v8
   - unknown/unknown

starting with v2-lts workflow only, iterate from here once it works
@alcohol alcohol force-pushed the multi-arch-matrix-pipeline branch 2 times, most recently from d715768 to 895550b Compare June 18, 2024 08:27
@alcohol alcohol marked this pull request as ready for review June 18, 2024 08:27
@alcohol alcohol force-pushed the multi-arch-matrix-pipeline branch from 895550b to e799497 Compare June 18, 2024 08:28
@alcohol alcohol force-pushed the multi-arch-matrix-pipeline branch from e799497 to 3db8658 Compare June 18, 2024 08:29
@tianon
Copy link
Contributor

tianon commented Jun 19, 2024

@alcohol
Copy link
Member Author

alcohol commented Jun 20, 2024

Honestly? Not really..

I do not really have enough spare time to dive very deep into this subject matter. I find it rather complex and not easy to comprehend. Things seems to work in the current shape of this PR though according to an end user who requested this feature, so I guess sufficient copy&paste and trial&error will make do for now 😅

@alcohol alcohol merged commit 2c5c50a into main Jun 20, 2024
32 checks passed
@alcohol alcohol deleted the multi-arch-matrix-pipeline branch June 20, 2024 09:31
@tianon
Copy link
Contributor

tianon commented Jun 20, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants