Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing readme_renderer dependency to twine #898

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

maresb
Copy link
Contributor

@maresb maresb commented Nov 6, 2024

Twine depends on readme_renderer depends on cmarkgfm. Cmarkgfm is compiled and doesn't exist for Python 3.13. I encountered an inconsistent solved environment with Python 3.13 and twine 1.13.0_0 because this build was missing those dependencies.

As an upcoming solution, I updated the stale cmarkgfm feedstock in conda-forge/cmarkgfm-feedstock#33, and I triggered a pending bot-rerun for the Python 3.13 rebuild in conda-forge/cmarkgfm-feedstock#32.

This patch is a retroactive solution.

Checklist

  • Used a static YAML file for the patch if possible (instructions).
  • Only wrote code directly into generate_patch_json.py if absolutely necessary.
  • Ran pre-commit run -a and ensured all files pass the linting checks.
  • Ran python show_diff.py and posted the output as part of the PR.
  • Modifications won't affect packages built in the future.
noarch
noarch::twine-1.13.0-py_0.tar.bz2
+    "readme_renderer >=21.0",

@maresb maresb requested a review from a team as a code owner November 6, 2024 14:01
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@xhochy
Copy link
Member

xhochy commented Nov 6, 2024

cc @conda-forge/twine

Copy link
Contributor

@bollwyvl bollwyvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xhochy xhochy merged commit 14ebf28 into conda-forge:main Nov 6, 2024
3 checks passed
@maresb maresb deleted the twine branch November 6, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants