Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stricter upper pin on dep wxwidgets #962

Merged
merged 5 commits into from
Feb 19, 2025
Merged

stricter upper pin on dep wxwidgets #962

merged 5 commits into from
Feb 19, 2025

Conversation

mahf708
Copy link
Contributor

@mahf708 mahf708 commented Feb 19, 2025 •
edited
Loading

Checklist

  • Used a static YAML file for the patch if possible (instructions).
  • Only wrote code directly into generate_patch_json.py if absolutely necessary.
  • Ran pre-commit run -a and ensured all files pass the linting checks.
  • Ran python show_diff.py and posted the output as part of the PR.
  • Modifications won't affect packages built in the future.

xref conda-forge/wxwidgets-feedstock#50
xref conda-forge/ncvis-climate-feedstock#15
xref wxWidgets/wxWidgets#25173

@mahf708 mahf708 requested a review from a team as a code owner February 19, 2025 15:01
@mahf708
Copy link
Contributor Author

mahf708 commented Feb 19, 2025

cc @hmaarrfk

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@mahf708 mahf708 mentioned this pull request Feb 19, 2025
Merged
2 tasks
@mahf708 mahf708 changed the title stricter pin on ncvis stricter upper pin on dep wxwidgets Feb 19, 2025
@mahf708
Copy link
Contributor Author

mahf708 commented Feb 19, 2025

show diff 

(xgns) mahf708@we46965 conda-forge-repodata-patches-feedstock % ./recipe/show_diff.py
================================================================================
================================================================================
linux-armv7l
================================================================================
================================================================================
win-32
================================================================================
================================================================================
linux-ppc64le
linux-ppc64le::hugin-2023.0.0-pl5321h0921b81_6.conda
linux-ppc64le::hugin-2023.0.0-pl5321h0de2ce8_2.conda
linux-ppc64le::hugin-2023.0.0-pl5321h4b81eff_3.conda
linux-ppc64le::hugin-2023.0.0-pl5321h64b637f_5.conda
linux-ppc64le::hugin-2023.0.0-pl5321hb6b20cf_4.conda
-    "wxwidgets >=3.2.5,<3.3.0a0",
+    "wxwidgets >=3.2.5,<3.2.6.0a0",
================================================================================
================================================================================
osx-arm64
osx-arm64::ncvis-climate-2024.01.26-h0468993_0.conda
osx-arm64::wxpython-4.2.1-py310hcf9f62a_7.conda
osx-arm64::wxpython-4.2.1-py310hfe860bb_6.conda
osx-arm64::wxpython-4.2.1-py311h3cb8de9_6.conda
osx-arm64::wxpython-4.2.1-py311hb9542d7_7.conda
osx-arm64::wxpython-4.2.1-py312h10d1a2f_6.conda
osx-arm64::wxpython-4.2.1-py312h5c2e7bc_7.conda
osx-arm64::wxpython-4.2.1-py38h11842c7_7.conda
osx-arm64::wxpython-4.2.1-py38h5123d71_6.conda
osx-arm64::wxpython-4.2.1-py39h65f9aa2_6.conda
osx-arm64::wxpython-4.2.1-py39hbf7db11_7.conda
-    "wxwidgets >=3.2.5,<3.3.0a0"
+    "wxwidgets >=3.2.5,<3.2.6.0a0"
================================================================================
================================================================================
linux-aarch64
linux-aarch64::hugin-2023.0.0-pl5321h04bab5f_6.conda
linux-aarch64::hugin-2023.0.0-pl5321h7408fd2_4.conda
linux-aarch64::hugin-2023.0.0-pl5321h7ae478e_3.conda
linux-aarch64::hugin-2023.0.0-pl5321hd727cfd_5.conda
linux-aarch64::hugin-2023.0.0-pl5321he4c141a_2.conda
-    "wxwidgets >=3.2.5,<3.3.0a0",
+    "wxwidgets >=3.2.5,<3.2.6.0a0",
================================================================================
================================================================================
noarch
================================================================================
================================================================================
win-64
win-64::hugin-2023.0.0-pl5321h19e30ba_3.conda
win-64::hugin-2023.0.0-pl5321h1b50584_5.conda
win-64::hugin-2023.0.0-pl5321h48be8e5_2.conda
win-64::hugin-2023.0.0-pl5321haee257c_6.conda
win-64::hugin-2023.0.0-pl5321he3d93f9_4.conda
win-64::wxpython-4.2.1-py310h9e98ed7_7.conda
win-64::wxpython-4.2.1-py310hfecb955_6.conda
win-64::wxpython-4.2.1-py311hcfbbcb8_6.conda
win-64::wxpython-4.2.1-py311hda3d55a_7.conda
win-64::wxpython-4.2.1-py312h275cf98_7.conda
win-64::wxpython-4.2.1-py312h649c44c_6.conda
win-64::wxpython-4.2.1-py38h2698bfa_7.conda
win-64::wxpython-4.2.1-py38hd30eb0f_6.conda
win-64::wxpython-4.2.1-py39ha51f57c_7.conda
win-64::wxpython-4.2.1-py39hb92dc96_6.conda
-    "wxwidgets >=3.2.5,<3.3.0a0"
+    "wxwidgets >=3.2.5,<3.2.6.0a0"
================================================================================
================================================================================
osx-64
osx-64::ncvis-climate-2024.01.26-hf793c56_0.conda
osx-64::wxpython-4.2.1-py310h19065b0_7.conda
osx-64::wxpython-4.2.1-py310h86f2fd1_6.conda
osx-64::wxpython-4.2.1-py311h45c2bf9_7.conda
osx-64::wxpython-4.2.1-py311h94cbb81_6.conda
osx-64::wxpython-4.2.1-py312h402197a_6.conda
osx-64::wxpython-4.2.1-py312h8ca7dfc_7.conda
osx-64::wxpython-4.2.1-py38h1dd216c_7.conda
osx-64::wxpython-4.2.1-py38ha7c3573_6.conda
osx-64::wxpython-4.2.1-py39h1fc617d_7.conda
osx-64::wxpython-4.2.1-py39he677a5e_6.conda
-    "wxwidgets >=3.2.5,<3.3.0a0"
+    "wxwidgets >=3.2.5,<3.2.6.0a0"
================================================================================
================================================================================
linux-64
linux-64::hugin-2023.0.0-pl5321h1c739b4_6.conda
linux-64::hugin-2023.0.0-pl5321h4ee2ee1_5.conda
linux-64::hugin-2023.0.0-pl5321h59ecf7d_2.conda
linux-64::hugin-2023.0.0-pl5321h8042ad0_4.conda
linux-64::hugin-2023.0.0-pl5321hd67d49b_3.conda
linux-64::wxpython-4.2.1-py310h76e45a6_7.conda
linux-64::wxpython-4.2.1-py310h809cb23_6.conda
linux-64::wxpython-4.2.1-py311h4332511_7.conda
linux-64::wxpython-4.2.1-py311ha420243_6.conda
linux-64::wxpython-4.2.1-py312h6847026_6.conda
linux-64::wxpython-4.2.1-py312h7070661_7.conda
linux-64::wxpython-4.2.1-py38h854fd01_7.conda
linux-64::wxpython-4.2.1-py38hbbe5ed4_6.conda
linux-64::wxpython-4.2.1-py39h3eb26e4_6.conda
linux-64::wxpython-4.2.1-py39h84cc369_7.conda
-    "wxwidgets >=3.2.5,<3.3.0a0",
+    "wxwidgets >=3.2.5,<3.2.6.0a0",
linux-64::ncvis-climate-2024.01.26-h2452fe5_0.conda
-    "wxwidgets >=3.2.5,<3.3.0a0"
+    "wxwidgets >=3.2.5,<3.2.6.0a0"
(xgns) mahf708@we46965 conda-forge-repodata-patches-feedstock % 
(xgns) mahf708@we46965 conda-forge-repodata-patches-feedstock % pre-commit run -a    
flake8...................................................................Passed
ruff.....................................................................Passed
black....................................................................Passed
yamllint.................................................................Passed
(xgns) mahf708@we46965 conda-forge-repodata-patches-feedstock %

@mahf708 mahf708 requested a review from hmaarrfk February 19, 2025 15:35
@mahf708 mahf708 requested a review from hmaarrfk February 19, 2025 17:15
@mahf708
Copy link
Contributor Author

mahf708 commented Feb 19, 2025

final show diff 

2025-02-19T17:17:00.7299412Z ============================== 2 passed in 1.83s ===============================
2025-02-19T17:17:01.7034806Z 
2025-02-19T17:17:02.6213553Z patching repodata:   0%|          | 0/9 [00:00<?, ?it/s]
2025-02-19T17:17:02.6215758Z 
2025-02-19T17:17:02.6215988Z ================================================================================
2025-02-19T17:17:02.6216602Z ================================================================================
2025-02-19T17:17:02.6217297Z linux-armv7l
2025-02-19T17:17:02.6217746Z 
2025-02-19T17:19:59.9976129Z patching repodata:  11%|█         | 1/9 [00:00<00:07,  1.09it/s]
2025-02-19T17:19:59.9976594Z 
2025-02-19T17:19:59.9980554Z ================================================================================
2025-02-19T17:19:59.9981165Z ================================================================================
2025-02-19T17:19:59.9981745Z linux-ppc64le
2025-02-19T17:19:59.9982050Z 
2025-02-19T17:20:24.3684396Z patching repodata:  22%|██▏       | 2/9 [02:58<12:13, 104.72s/it]
2025-02-19T17:20:24.3702068Z 
2025-02-19T17:20:24.3702304Z ================================================================================
2025-02-19T17:20:24.3702906Z ================================================================================
2025-02-19T17:20:24.3703358Z linux-aarch64
2025-02-19T17:20:24.3703586Z 
2025-02-19T17:20:50.6683357Z patching repodata:  33%|███▎      | 3/9 [03:22<06:48, 68.03s/it] 
2025-02-19T17:20:50.6683820Z 
2025-02-19T17:20:50.6683976Z ================================================================================
2025-02-19T17:20:50.6684437Z ================================================================================
2025-02-19T17:20:50.6684851Z noarch
2025-02-19T17:20:50.6685010Z 
2025-02-19T17:21:15.4161378Z 
2025-02-19T17:21:15.4162245Z ================================================================================
2025-02-19T17:21:15.4163052Z ================================================================================
2025-02-19T17:21:15.4164542Z win-32
2025-02-19T17:21:15.4165111Z 
2025-02-19T17:21:15.4171288Z patching repodata:  44%|████▍     | 4/9 [03:48<04:17, 51.55s/it]
2025-02-19T17:23:38.0498174Z 
2025-02-19T17:23:38.0499543Z ================================================================================
2025-02-19T17:23:38.0500219Z ================================================================================
2025-02-19T17:23:38.0501739Z osx-arm64
2025-02-19T17:23:38.0502152Z osx-arm64::wxpython-4.2.1-py39hbf7db11_7.conda
2025-02-19T17:23:38.0502658Z osx-arm64::wxpython-4.2.1-py38h11842c7_7.conda
2025-02-19T17:23:38.0506331Z patching repodata:  56%|█████▌    | 5/9 [04:13<02:47, 41.89s/it]
2025-02-19T17:23:38.0508660Z osx-arm64::wxpython-4.2.1-py310hfe860bb_6.conda
2025-02-19T17:23:38.0509122Z osx-arm64::wxpython-4.2.1-py312h10d1a2f_6.conda
2025-02-19T17:23:38.0509553Z osx-arm64::wxpython-4.2.1-py311h3cb8de9_6.conda
2025-02-19T17:23:38.0510002Z osx-arm64::wxpython-4.2.1-py39h65f9aa2_6.conda
2025-02-19T17:23:38.0510434Z osx-arm64::wxpython-4.2.1-py312h5c2e7bc_7.conda
2025-02-19T17:23:38.0510851Z osx-arm64::wxpython-4.2.1-py311hb9542d7_7.conda
2025-02-19T17:23:38.0511269Z osx-arm64::wxpython-4.2.1-py310hcf9f62a_7.conda
2025-02-19T17:23:38.0511698Z osx-arm64::wxpython-4.2.1-py38h5123d71_6.conda
2025-02-19T17:23:38.0512137Z osx-arm64::ncvis-climate-2024.01.26-h0468993_0.conda
2025-02-19T17:23:38.0512898Z -    "wxwidgets >=3.2.5,<3.3.0a0"
2025-02-19T17:23:38.0513230Z +    "wxwidgets >=3.2.5,<3.2.6.0a0"
2025-02-19T17:23:38.0513467Z 
2025-02-19T17:25:42.9414883Z 
2025-02-19T17:25:42.9415329Z ================================================================================
2025-02-19T17:25:42.9415849Z ================================================================================
2025-02-19T17:25:42.9416253Z linux-64
2025-02-19T17:25:42.9416418Z 
2025-02-19T17:25:42.9417006Z patching repodata:  67%|██████▋   | 6/9 [06:36<03:48, 76.14s/it]
2025-02-19T17:26:30.5803994Z patching repodata:  78%|███████▊  | 7/9 [08:41<03:04, 92.08s/it]
2025-02-19T17:26:30.5804475Z 
2025-02-19T17:26:30.5804660Z ================================================================================
2025-02-19T17:26:30.5805154Z ================================================================================
2025-02-19T17:26:30.5805587Z win-64
2025-02-19T17:26:30.5805759Z 
2025-02-19T17:26:53.0125354Z 
2025-02-19T17:26:53.0126961Z patching repodata:  89%|████████▉ | 8/9 [09:28<01:17, 77.93s/it]
2025-02-19T17:26:53.0127765Z ================================================================================
2025-02-19T17:26:53.0128219Z ================================================================================
2025-02-19T17:26:53.0128608Z osx-64
2025-02-19T17:26:53.0128967Z osx-64::wxpython-4.2.1-py39he677a5e_6.conda
2025-02-19T17:26:53.0129452Z osx-64::wxpython-4.2.1-py38ha7c3573_6.conda
2025-02-19T17:26:53.0129939Z osx-64::wxpython-4.2.1-py311h45c2bf9_7.conda
2025-02-19T17:26:53.0130453Z osx-64::wxpython-4.2.1-py312h8ca7dfc_7.conda
2025-02-19T17:26:53.0130894Z osx-64::wxpython-4.2.1-py310h86f2fd1_6.conda
2025-02-19T17:26:53.0131326Z osx-64::wxpython-4.2.1-py38h1dd216c_7.conda
2025-02-19T17:26:53.0131732Z osx-64::wxpython-4.2.1-py311h94cbb81_6.conda
2025-02-19T17:26:53.0132188Z osx-64::ncvis-climate-2024.01.26-hf793c56_0.conda
2025-02-19T17:26:53.0132658Z osx-64::wxpython-4.2.1-py39h1fc617d_7.conda
2025-02-19T17:26:53.0133088Z osx-64::wxpython-4.2.1-py312h402197a_6.conda
2025-02-19T17:26:53.0133517Z osx-64::wxpython-4.2.1-py310h19065b0_7.conda
2025-02-19T17:26:53.0133912Z -    "wxwidgets >=3.2.5,<3.3.0a0"
2025-02-19T17:26:53.0134267Z +    "wxwidgets >=3.2.5,<3.2.6.0a0"
2025-02-19T17:26:53.0134910Z patching repodata: 100%|██████████| 9/9 [09:51<00:00, 60.58s/it]
2025-02-19T17:26:53.0135587Z patching repodata: 100%|██████████| 9/9 [09:51<00:00, 65.70s/it]
2025-02-19T17:26:53.0135922Z

@hmaarrfk hmaarrfk merged commit 28d68e6 into conda-forge:main Feb 19, 2025
3 checks passed
@mahf708 mahf708 mentioned this pull request Feb 19, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmaarrfk hmaarrfk Awaiting requested review from hmaarrfk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mahf708 @conda-forge-admin @hmaarrfk