Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rc] Add patches for WASM support #67

Draft
wants to merge 6 commits into
base: rc
Choose a base branch
from

Conversation

h-vetinari
Copy link
Member

This is a forward-port of #58 from @IsabelParedes; we'll need to solve #63, and I think we'll need to build a non-trivial portion of the LLVM stack for emscripten (especially compiler-rt), which probably means bootstrapping that entire target.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@h-vetinari h-vetinari force-pushed the wasm branch 3 times, most recently from 505d97a to 172f1f0 Compare August 4, 2024 21:45
recipe/meta.yaml Outdated
Comment on lines 15 to 20
# see https://github.com/llvm/llvm-project/pull/99465
- patches/0004-Fix-implicit-conversion-warning-when-targeting-32bit.patch
# see https://github.com/llvm/llvm-project/pull/99822
- patches/0005-Explicitly-convert-shift-value-to-SubscriptValue.patch
# see https://github.com/llvm/llvm-project/pull/101242
- patches/0006-Handle-missing-definitions-in-cfenv.patch
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So llvm/llvm-project@6db2465 already landed before 19.1.0.rc1 (so it needs to be dropped), while the commits for patch 0006 don't apply on the 19.x branch (due to llvm/llvm-project@4cdc19b). I'm tentatively adding that patch as a backport as well for now, even though it's larger than I'd normally be comfortable with.

@h-vetinari
Copy link
Member Author

In general, all the work on patches should be happening on an actual git checkout, otherwise we'll be running into conflicts constantly. I put the branch I'm using for flang 19 here for you, you can check it out and rebase/modify it as necessary. The patches are then generated using:

git format-patch tags/llvmorg-19.1.0-rc2 --no-signature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants