fix: code cleanup #2297
Open
fix: code cleanup #2297
+73
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tfrisch06 - thanks for your PR. Some of your improvements have already been merge, so can you please rebase to resolve the conflicts. |
|
@tfrisch06 - it doesn't look like you have rebased properly as there are three commits including a merge one? |
tfrisch06
force-pushed
the
review
branch
3 times, most recently
from
ed4be23 to
7dce2e4
Compare
Signed-off-by: Tanner <tfrisch06@icloud.com>
ldoktor
reviewed
Feb 19, 2025
There was a problem hiding this comment.
Is this an automated refacoring or manual one? If the first one then it'd make sense to include it in CI so we start enforcing consistent style across this project, what do you think?
Overall it looks fine although I'm not a golang person so don't feel confident acking this PR. Provided len() can't return <0 numbers in go it looks safe, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.