resource-uri: handle two-part resource paths #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two-part resource paths have so far resulted in an error. This however seems incorrect since the repository part of a resource path is specified as optional in the kbs-protocol definition(*). This change could conceivably break a caller that relies on ResourceUri to bail out if a resource path only has two parts. Arguably such a caller would itself be faulty though, given the kbs-protocol definition. (*) https://github.com/confidential-containers/trustee/blob/main/kbs/docs/kbs_attestation_protocol.md#secret-resource Signed-off-by: Pavel Mores <pmores@redhat.com>
|
Please do review carefully since I'm very new here and chances of me overlooking something are definitely solidly non-zero. |
fitzthum
approved these changes
Feb 20, 2025
| let (repository, r#type, tag) = if values.len() == 3 { | ||
| (values[0].into(), values[1].into(), values[2].into()) | ||
| } else if values.len() == 2 { | ||
| println!("two-part resource path, filling in \"default\" for repository"); |
There was a problem hiding this comment.
probably want to use log::info! here instead
|
Please see my comment confidential-containers/trustee#712 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two-part resource paths have so far resulted in an error. This however seems incorrect since the repository part of a resource path is specified as optional in the kbs-protocol definition(*).
This change could conceivably break a caller that relies on ResourceUri to bail out if a resource path only has two parts. Arguably such a caller would itself be faulty though, given the kbs-protocol definition.
(*) https://github.com/confidential-containers/trustee/blob/main/kbs/docs/kbs_attestation_protocol.md#secret-resource