cdh: allow Trustee to bump Aliyun KMS plugin #919
Merged
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To build aliyun KMS plugin, anyhow and serde are mandatory dependencies. Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
confidentia-data-hub does not build when selected features are pulled via dependencies (aliyun KMS plugin). Bigger re-work is needed to redefine modules' visibility and make the crate usable for as a dependency. The hack is to just make the build to succeed by making cfg-if and config as mandatory dependencies for all builds. The downside is this will currently pull unnecessary dependencies to users (IOW: Trustee depends on image-rs etc). Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
Xynnn007
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not an ideal fix but allows trustee to keep both of its guest-components dependencies pointing to the same version.
More details: #816 (comment)