Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix llama-run to be installed with correct library paths. #549

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Jan 7, 2025

Fixes: #548

Summary by Sourcery

Chores:

  • Update version in pyproject.toml, python-ramalama.spec, and setup.py.

Copy link
Contributor

sourcery-ai bot commented Jan 7, 2025

Reviewer's Guide by Sourcery

This pull request bumps the version of ramalama to v0.4.0.

State diagram for version update

stateDiagram-v2
    v0.3.0 --> v0.4.0: Version bump
    note right of v0.4.0
        Updated in:
        - pyproject.toml
        - setup.py
        - rpm spec file
    end note
Loading

File-Level Changes

Change Details Files
The version was bumped from 0.3.0 to 0.4.0.
  • The version in pyproject.toml was updated.
  • The version in rpm/python-ramalama.spec was updated.
  • The version in setup.py was updated.
pyproject.toml
rpm/python-ramalama.spec
setup.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rhatdan - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@rhatdan rhatdan changed the title Bump to v0.4.0 [WIP] Bump to v0.4.0 Jan 7, 2025
This reverts commit 8f92ca3.
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@rhatdan rhatdan force-pushed the version branch 2 times, most recently from f56d818 to 5e86f58 Compare January 7, 2025 21:45
@rhatdan rhatdan changed the title [WIP] Bump to v0.4.0 Fix llama-run to be installed with correct library paths. Jan 7, 2025
@rhatdan rhatdan merged commit 956f8f7 into containers:main Jan 8, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot run a model container - macOS, error loading shared library
2 participants