Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update llama.cpp to contain llama-run fix #556

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Update llama.cpp to contain llama-run fix #556

merged 1 commit into from
Jan 9, 2025

Conversation

ericcurtin
Copy link
Collaborator

@ericcurtin ericcurtin commented Jan 9, 2025

This version of llama.cpp has fixes which help exit llama-run, before Ctrl-C and CTRL-D were failing to exit llama-run.

Summary by Sourcery

Update llama.cpp to a version that fixes issues with exiting llama-run using Ctrl-C and Ctrl-D.

Bug Fixes:

  • Fix issues where Ctrl-C and Ctrl-D would not exit llama-run.

Build:

  • Update the llama.cpp SHA to f8feb4b01af374ad2fce302fd5790529c615710b.

This version of llama.cpp has fixes which help exit llama-run,
before Ctrl-C and CTRL-D were failing to exit llama-run.

Signed-off-by: Eric Curtin <ecurtin@redhat.com>
Copy link
Contributor

sourcery-ai bot commented Jan 9, 2025

Reviewer's Guide by Sourcery

This pull request updates the llama.cpp dependency to a newer version (f8feb4b01af374ad2fce302fd5790529c615710b) which includes a fix for exiting llama-run. Previously, Ctrl-C and Ctrl-D were not working as expected.

Sequence diagram for llama-run exit behavior

sequenceDiagram
    actor User
    participant LR as llama-run
    participant OS as Operating System

    Note over User, OS: Before Fix
    User->>LR: Press Ctrl-C/Ctrl-D
    LR-->>User: No response (continues running)

    Note over User, OS: After Fix
    User->>LR: Press Ctrl-C/Ctrl-D
    LR->>OS: Process termination signal
    OS-->>LR: Acknowledge termination
    LR-->>User: Program exits
Loading

State diagram for llama-run process control

stateDiagram-v2
    [*] --> Running
    Running --> Running: Ctrl-C/Ctrl-D (Before Fix)
    Running --> [*]: Ctrl-C/Ctrl-D (After Fix)
    note right of Running
        Fix enables proper signal handling
        for graceful termination
    end note
Loading

File-Level Changes

Change Details Files
Update llama.cpp to a newer version
  • Updated the llama_cpp_sha from a4dd490069a66ae56b42127048f06757fc4de4f7 to f8feb4b01af374ad2fce302fd5790529c615710b
container-images/scripts/build_llama_and_whisper.sh

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ericcurtin - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please include a link to the upstream PR/issue that fixed the exit behavior and document any other significant changes included in this llama.cpp version update
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ericcurtin
Copy link
Collaborator Author

The diagram generated in this PR is actually quite impressive

@rhatdan
Copy link
Member

rhatdan commented Jan 9, 2025

LGTM

@rhatdan rhatdan merged commit 603de7c into main Jan 9, 2025
12 checks passed
@ericcurtin ericcurtin deleted the ctrl-c branch January 9, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants