-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update llama.cpp to contain llama-run fix #556
Conversation
This version of llama.cpp has fixes which help exit llama-run, before Ctrl-C and CTRL-D were failing to exit llama-run. Signed-off-by: Eric Curtin <ecurtin@redhat.com>
Reviewer's Guide by SourceryThis pull request updates the llama.cpp dependency to a newer version (f8feb4b01af374ad2fce302fd5790529c615710b) which includes a fix for exiting llama-run. Previously, Ctrl-C and Ctrl-D were not working as expected. Sequence diagram for llama-run exit behaviorsequenceDiagram
actor User
participant LR as llama-run
participant OS as Operating System
Note over User, OS: Before Fix
User->>LR: Press Ctrl-C/Ctrl-D
LR-->>User: No response (continues running)
Note over User, OS: After Fix
User->>LR: Press Ctrl-C/Ctrl-D
LR->>OS: Process termination signal
OS-->>LR: Acknowledge termination
LR-->>User: Program exits
State diagram for llama-run process controlstateDiagram-v2
[*] --> Running
Running --> Running: Ctrl-C/Ctrl-D (Before Fix)
Running --> [*]: Ctrl-C/Ctrl-D (After Fix)
note right of Running
Fix enables proper signal handling
for graceful termination
end note
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ericcurtin - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please include a link to the upstream PR/issue that fixed the exit behavior and document any other significant changes included in this llama.cpp version update
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
The diagram generated in this PR is actually quite impressive |
LGTM |
This version of llama.cpp has fixes which help exit llama-run, before Ctrl-C and CTRL-D were failing to exit llama-run.
Summary by Sourcery
Update llama.cpp to a version that fixes issues with exiting llama-run using Ctrl-C and Ctrl-D.
Bug Fixes:
Build: