Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update llama.cpp to include minor llama-run #580

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Conversation

ericcurtin
Copy link
Collaborator

@ericcurtin ericcurtin commented Jan 12, 2025

Around resetting color output

Summary by Sourcery

Build:

  • Update the commit SHA for llama.cpp in the build script.

Around resetting color output

Signed-off-by: Eric Curtin <ecurtin@redhat.com>
Copy link
Contributor

sourcery-ai bot commented Jan 12, 2025

Reviewer's Guide by Sourcery

This pull request updates the llama.cpp submodule to a newer commit to include minor llama-run changes around resetting color output.

Flow diagram for llama.cpp build update process

graph TD
    A[Start Build Script] --> B[Clone llama.cpp repository]
    B --> C[Checkout specific commit]
    C --> |Updated SHA: 924518e| D[Build llama.cpp]
    D --> E[End Build Script]
    style C fill:#f9f,stroke:#333,stroke-width:2px
Loading

File-Level Changes

Change Details Files
Update llama.cpp commit SHA
  • Updated the commit SHA for llama.cpp from f8feb4b01af374ad2fce302fd5790529c615710b to 924518e2e5726e81f3aeb2518fb85963a500e93a.
container-images/scripts/build_llama_and_whisper.sh

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ericcurtin - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please provide a more detailed description of the changes introduced by this SHA update. What specific improvements or fixes does it bring, particularly regarding the 'minor llama-run' and color output changes mentioned?
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@rhatdan
Copy link
Member

rhatdan commented Jan 13, 2025

LGTM

@rhatdan rhatdan merged commit a62b6e4 into main Jan 13, 2025
12 checks passed
@ericcurtin ericcurtin deleted the update-llama.cpp branch January 13, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants