-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build with curl support #595
Conversation
Reviewer's Guide by SourceryThis pull request introduces curl support to the standalone container image, enabling it to download models. This change is beneficial for using the container as a Home Assistant addon. Sequence diagram for model download process with curlsequenceDiagram
participant Container as Ramalama Container
participant Curl as Curl Library
participant Repo as Model Repository
Container->>Curl: Initialize curl
Container->>Curl: Request model download
Curl->>Repo: HTTP GET request
Repo-->>Curl: Send model file
Curl-->>Container: Return downloaded model
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This allows the standalone container to download models Signed-off-by: Pepijn de Vos <pepijndevos@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @pepijndevos - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please add documentation covering the new curl-based download capability, including security considerations (network access, model validation) and any safeguards in place for the download process.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
I guess we can add this, it's a little unnecessary as "ramalama run/ramalama pull" has it's own http client for pulling |
I am fine with this. |
This allows the standalone container to download models
As proposed in #575 this is useful to use ramalama containers as Home Assistant addons.
Summary by Sourcery
Build: