-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert back to 12.6 version of cuda #864
Conversation
This is breaking workloads on Fedora 41 at this time. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Reviewer's Guide by SourceryThis pull request reverts the CUDA version used in the container images back to 12.6.0 due to compatibility issues with Fedora 41. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @rhatdan - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a comment in the Dockerfile itself explaining why the older CUDA version is necessary.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
CI images build doesn't even build this container image anymore trying to fix that elsewhere... Merging |
This is breaking workloads on Fedora 41 at this time.
Summary by Sourcery
Chores: