Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert back to 12.6 version of cuda #864

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Feb 20, 2025

This is breaking workloads on Fedora 41 at this time.

Summary by Sourcery

Chores:

  • Revert the CUDA base image version back to 12.6 to address compatibility issues on Fedora 41.

This is breaking workloads on Fedora 41 at this time.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Copy link
Contributor

sourcery-ai bot commented Feb 20, 2025

Reviewer's Guide by Sourcery

This pull request reverts the CUDA version used in the container images back to 12.6.0 due to compatibility issues with Fedora 41.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Revert CUDA version from 12.8.0 to 12.6.0.
  • Changed the base image for the builder stage from nvidia/cuda:12.8.0-devel-ubi9 to nvidia/cuda:12.6.0-devel-ubi9.
  • Changed the base image for the runtime stage from nvidia/cuda:12.8.0-runtime-ubi9 to nvidia/cuda:12.6.0-runtime-ubi9.
container-images/cuda/Containerfile

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rhatdan - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a comment in the Dockerfile itself explaining why the older CUDA version is necessary.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ericcurtin
Copy link
Collaborator

CI images build doesn't even build this container image anymore trying to fix that elsewhere... Merging

@ericcurtin ericcurtin merged commit c5054f1 into containers:main Feb 20, 2025
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants