Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display emoji of the engine for the run in the prompt #872

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Feb 23, 2025

Add emoji prompt with the engine

  • podman: 🦭 >
  • native: 🦙 >
  • docker: 🐋 >

I had to bump the sha to build a more recent version of the llama-run for the ramalama image

I checked on macOS and inside a container (docker or podman) but not on Linux natively so 🤷

fixes #783

Summary by Sourcery

This pull request introduces an emoji prompt to indicate the engine being used (Podman, Docker, or native) when running the run subcommand. It also updates the llama.cpp SHA and fixes an issue with the prompt prefix.

New Features:

  • Introduces a new feature that displays an emoji prompt based on the engine used for the run command: Podman (🦭), Docker (🐋), and native (🦙).

Bug Fixes:

  • Fixes an issue where the prompt prefix was not being displayed correctly in certain environments.

Build:

  • Updates the llama.cpp SHA to build a more recent version for the ramalama image.

fixes containers#783

Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Copy link
Contributor

sourcery-ai bot commented Feb 23, 2025

Reviewer's Guide by Sourcery

This pull request introduces engine-specific emoji prefixes to the prompt for the run subcommand, enhancing the user experience by visually indicating the engine in use. It also updates the llama.cpp SHA to build a more recent version.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added engine-specific emoji prefixes to the prompt for the run subcommand.
  • Added logic to set the LLAMA_PROMPT_PREFIX environment variable based on the engine being used (podman or docker).
  • The podman engine now uses the seal emoji: 🦭 > .
  • The docker engine now uses the whale emoji: 🐋 > .
  • If the LLAMA_PROMPT_PREFIX environment variable is not already set, it defaults to the llama emoji: 🦙 > .
ramalama/model.py
Updated the llama.cpp SHA to build a more recent version.
  • Bumped the llama_cpp_sha to 7ad0779f5de84a68143b2c00ab5dc94a948925d3.
container-images/scripts/build_llama_and_whisper.sh

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @benoitf - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider defining the engine-to-emoji mapping in a dictionary for better readability and maintainability.
  • The logic for setting LLAMA_PROMPT_PREFIX seems duplicated; can it be consolidated?
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@rhatdan
Copy link
Member

rhatdan commented Feb 23, 2025

LGTM

@rhatdan rhatdan merged commit 7d304a4 into containers:main Feb 24, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display the provider/engine being used to run the model
2 participants