benchmark failing because of lack of flag

[ericcurtin]

Specifically priviledged because it's not present in the args object.

Summary by Sourcery

Fixes a bug where the bench command was missing some arguments. This change introduces a new function bench_run_serve_perplexity_args to define arguments shared between bench, run and serve commands. The ngl argument was removed from the bench command and is now loaded from the model.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request introduces a new function bench_run_serve_perplexity_args to consolidate shared arguments between the bench, run, serve, and perplexity commands. It refactors the bench_parser and run_serve_perplexity_args functions to use the new function, removing duplicate argument definitions.

Updated class diagram for CLI argument parsing

classDiagram
    class bench_parser{
        +MODEL
        +func
    }
    class run_serve_perplexity_args{
        +ctx_size
    }
    class bench_run_serve_perplexity_args{
        +authfile
        +device
    }
    bench_parser -- bench_run_serve_perplexity_args : uses
    run_serve_perplexity_args -- bench_run_serve_perplexity_args : uses
    note for bench_parser "Arguments for benchmarking"
    note for run_serve_perplexity_args "Arguments for running, serving, and perplexity"
    note for bench_run_serve_perplexity_args "Shared arguments"

Loading

File-Level Changes

Change	Details	Files
Introduces a new function bench_run_serve_perplexity_args to consolidate arguments shared between bench, run, serve, and perplexity commands.	Created bench_run_serve_perplexity_args function. Moved --authfile argument definition to bench_run_serve_perplexity_args. Moved --device argument definition to bench_run_serve_perplexity_args. Moved --ctx-size argument definition to bench_run_serve_perplexity_args.	ramalama/cli.py
Refactors the bench_parser and run_serve_perplexity_args functions to use the new bench_run_serve_perplexity_args function.	Called bench_run_serve_perplexity_args in bench_parser. Removed duplicate --ngl argument definition from bench_parser. Called bench_run_serve_perplexity_args in run_serve_perplexity_args.	ramalama/cli.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @ericcurtin - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider renaming bench_run_serve_perplexity_args to something more descriptive, as it's now used in multiple contexts.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[rhatdan]

Can you add a test to run bench without checking for output, to at least catch crashes.

[rhatdan]

LGTM