-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handling of date with python 3.8/3.9/3.10 #897
Conversation
Reviewer's Guide by SourceryThe pull request modifies the date formatting in Sequence diagram for listing modelssequenceDiagram
participant User
participant CLI
participant OCI Registry
User->>CLI: Request to list models
CLI->>OCI Registry: List manifests (includes 'modified' date)
OCI Registry-->>CLI: Manifests data (with 'modified' in string format)
CLI->>CLI: Parse 'modified' date string to datetime object
CLI->>CLI: Convert datetime object to ISO format
CLI-->>User: List of models (with 'modified' in ISO format)
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @benoitf - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a unit test to specifically cover the date format being handled here.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
use a function working on 3.9+ Signed-off-by: Florent Benoit <fbenoit@redhat.com>
use a function working on 3.8+
it was working with python 3.11+
Summary by Sourcery
Bug Fixes: