Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handling of date with python 3.8/3.9/3.10 #897

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Feb 28, 2025

use a function working on 3.8+

it was working with python 3.11+

Summary by Sourcery

Bug Fixes:

  • Fixes date parsing to be compatible with Python 3.8+

Copy link
Contributor

sourcery-ai bot commented Feb 28, 2025

Reviewer's Guide by Sourcery

The pull request modifies the date formatting in ramalama/oci.py to ensure compatibility with Python 3.9 and 3.10. The datetime.fromisoformat function is used to parse the date string, and the date string is preprocessed to replace '+0000' with '+00:00' to ensure that it is properly parsed.

Sequence diagram for listing models

sequenceDiagram
    participant User
    participant CLI
    participant OCI Registry

    User->>CLI: Request to list models
    CLI->>OCI Registry: List manifests (includes 'modified' date)
    OCI Registry-->>CLI: Manifests data (with 'modified' in string format)
    CLI->>CLI: Parse 'modified' date string to datetime object
    CLI->>CLI: Convert datetime object to ISO format
    CLI-->>User: List of models (with 'modified' in ISO format)
Loading

File-Level Changes

Change Details Files
The date formatting was updated to be compatible with Python 3.9 and 3.10.
  • Replaced '+0000' with '+00:00' in the date string before parsing it.
ramalama/oci.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @benoitf - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a unit test to specifically cover the date format being handled here.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

use a function working on 3.9+

Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@benoitf benoitf changed the title fix: handling of date with python 3.9/3.10 fix: handling of date with python 3.8/3.9/3.10 Feb 28, 2025
@ericcurtin ericcurtin merged commit 1e61963 into containers:main Feb 28, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants