Skip to content

fix: pass batch size to getMany requests [FUS-561] #1062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025

Conversation

screamcha
Copy link
Contributor

@screamcha screamcha commented May 30, 2025

The CDA has a limit of 100 items for the getMany content types call regardless of the number of passed ids for filtering. It creates issues when request batch size is bigger (e.g. 300). This PR passes the batch size as a filter value.

@screamcha screamcha requested a review from a team as a code owner May 30, 2025 14:03
@screamcha screamcha force-pushed the fix/fus-561-pass-limit-to-cda-request branch from d12800b to 2b89faf Compare May 30, 2025 14:18
Copy link

@vikaskumr vikaskumr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test case if it is easy to test?

@screamcha screamcha merged commit 937e7bb into main Jun 2, 2025
10 checks passed
@screamcha screamcha deleted the fix/fus-561-pass-limit-to-cda-request branch June 2, 2025 10:51
@contentful-automation
Copy link

🎉 This PR is included in version 2.6.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants