Skip to content

Commit 42e6982

Browse files
feat: [Groot-1484] Update types in the CDA library with taxonomy asset support
1 parent 5f4c6c3 commit 42e6982

File tree

5 files changed

+13
-9
lines changed

5 files changed

+13
-9
lines changed

lib/types/asset.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { ContentfulCollection } from './collection'
22
import { LocaleCode } from './locale'
3-
import { AssetMetadata } from './metadata'
3+
import { Metadata } from './metadata'
44
import { EntitySys } from './sys'
55
import { ChainModifiers } from './client'
66

@@ -53,7 +53,7 @@ export interface Asset<
5353
: 'WITH_ALL_LOCALES' extends Modifiers
5454
? { [FieldName in keyof AssetFields]: { [LocaleName in Locales]?: AssetFields[FieldName] } }
5555
: AssetFields
56-
metadata: AssetMetadata
56+
metadata: Metadata
5757
}
5858

5959
/**

lib/types/metadata.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,3 @@ export type Metadata = {
88
tags: { sys: TagLink }[]
99
concepts?: { sys: TaxonomyConceptLink }[]
1010
}
11-
12-
export type AssetMetadata = Omit<Metadata, 'concepts'>

lib/types/query/query.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -183,6 +183,7 @@ export type AssetsQueries<
183183
> = AssetFieldsQueries<Fields> &
184184
AssetFieldsFileQueries &
185185
AssetFieldsFileDetailsQueries &
186+
MetadataConceptsQueries &
186187
SysQueries<Pick<AssetSys, 'createdAt' | 'updatedAt' | 'revision' | 'id' | 'type'>> &
187188
MetadataTagsQueries &
188189
FixedQueryOptions &

lib/types/query/select.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { FieldsType } from './util'
22
import { EntrySys } from '../entry'
33
import { AssetSys } from '../asset'
4-
import { AssetMetadata, Metadata } from '../metadata'
4+
import { Metadata } from '../metadata'
55

66
export type SelectFilterPaths<
77
Fields extends FieldsType,
@@ -51,6 +51,6 @@ export type AssetSelectFilter<Fields extends FieldsType> = {
5151
| 'fields'
5252
| SelectFilterPaths<Fields, 'fields'>
5353
| 'metadata'
54-
| SelectFilterPaths<AssetMetadata, 'metadata'>
54+
| SelectFilterPaths<Metadata, 'metadata'>
5555
)[]
5656
}

test/types/queries/asset-queries.test-d.ts

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,6 @@ type DefaultAssetQueries = AssetsQueries<AssetFields, undefined>
88

99
expectAssignable<DefaultAssetQueries>({
1010
'metadata.tags.sys.id[all]': mocks.stringArrayValue,
11-
})
12-
13-
expectNotAssignable<DefaultAssetQueries>({
1411
'metadata.concepts.sys.id[all]': mocks.stringArrayValue,
1512
})
1613

@@ -45,8 +42,14 @@ expectAssignable<DefaultAssetQueries>({
4542
'fields.file.url[exists]': mocks.booleanValue,
4643
'fields.title[exists]': mocks.booleanValue,
4744
'metadata.tags[exists]': mocks.booleanValue,
45+
'metadata.concepts[exists]': mocks.booleanValue,
4846
'sys.updatedAt[exists]': mocks.booleanValue,
4947
})
48+
expectAssignable<DefaultAssetQueries>({
49+
'metadata.tags.sys.id[all]': mocks.stringArrayValue,
50+
'metadata.concepts.sys.id[all]': mocks.stringArrayValue,
51+
'metadata.concepts.descendants[in]': mocks.stringArrayValue,
52+
})
5053
expectNotAssignable<DefaultAssetQueries>({
5154
'fields.unknownField[exists]': mocks.anyValue,
5255
})
@@ -84,6 +87,7 @@ expectAssignable<DefaultAssetQueries>({
8487
'fields.file.url[in]': mocks.stringArrayValue,
8588
'fields.title[in]': mocks.stringArrayValue,
8689
'metadata.tags.sys.id[in]': mocks.stringArrayValue,
90+
'metadata.concepts.sys.id[in]': mocks.stringArrayValue,
8791
'sys.updatedAt[in]': mocks.dateArrayValue,
8892
})
8993
expectNotAssignable<DefaultAssetQueries>({
@@ -154,6 +158,7 @@ expectAssignable<DefaultAssetQueries>({
154158
'fields.file.url[nin]': mocks.stringArrayValue,
155159
'fields.title[nin]': mocks.stringArrayValue,
156160
'metadata.tags.sys.id[nin]': mocks.stringArrayValue,
161+
'metadata.concepts.sys.id[nin]': mocks.stringArrayValue,
157162
'sys.updatedAt[nin]': mocks.dateArrayValue,
158163
})
159164
expectNotAssignable<DefaultAssetQueries>({

0 commit comments

Comments
 (0)