Skip to content

feat: post release cleanup [INTEG-2586] #5007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 19, 2025
Merged

Conversation

mgoudy91
Copy link
Contributor

@mgoudy91 mgoudy91 commented May 16, 2025

Purpose

  • Use space default locale instead of en-us

  • Use better default params for config model options

  • fix the dang tests

@mgoudy91 mgoudy91 force-pushed the INTEG-2586/post-release-cleanup branch from 90269eb to 5fbe5b7 Compare May 16, 2025 21:45
@mgoudy91 mgoudy91 changed the title Integ 2586/post release cleanup feat: post release cleanup [INTEG-2586] May 16, 2025
@mgoudy91 mgoudy91 marked this pull request as ready for review May 16, 2025 21:47
@mgoudy91 mgoudy91 requested a review from a team as a code owner May 16, 2025 21:47
textModelId: 'meta-llama/Llama-3.2-3B-Instruct',
textModelInferenceProvider: 'hf-inference',
textModelId: 'Qwen/Qwen2.5-VL-7B-Instruct',
textModelInferenceProvider: 'hyperbolic',
imageModelId: 'black-forest-labs/FLUX.1-dev',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we should also find an image model that doesn't first require a consent too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I thought that one did. ill look around

Copy link
Contributor

@primeinteger primeinteger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👏

@mgoudy91 mgoudy91 added this pull request to the merge queue May 19, 2025
Merged via the queue into main with commit 39e2d6a May 19, 2025
11 checks passed
@mgoudy91 mgoudy91 deleted the INTEG-2586/post-release-cleanup branch May 19, 2025 19:24
@github-actions github-actions bot mentioned this pull request May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants