Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some support for unicode-range and @font-face{font-weight}. #9

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

galenhuntington
Copy link

Ref #8.

I don't know or really understand this codebase, but I gave it a shot.

  • unicode-range now at least doesn't get mangled, although the parser is primitive and doesn't try to minify.

  • font-weight mostly works, but font-weight: normal bold gets changed to font-weight:700, which is wrong, and I haven't yet figured out why normal gets eaten. One question is whether it's better to leave this bug or defer support.

@contivero
Copy link
Owner

contivero commented May 23, 2020

Thanks! My apologies for the silence, you caught me in a very busy time in my life unfortunately :/
I'll try to work off this to add support while fixing the bug you mentioned. Do you need this fast, or can you wait for me a bit longer?

On a side note, do you mind me asking in which context are you using this project (is it the library or the stand alone executable?). Just curious as to how people are using this.

@galenhuntington
Copy link
Author

There's no particular hurry from my end. The above code changes sufficed, and anyway I gave up trying for pure Haskell solutions for that project, and went with Node libraries, largely because I needed Node in the stack anyway for Stylus. I was using the Hasmin library, called from a Shake build file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants