Refactor: Remove deprecated / unused regional analysis fields #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove old fields that are no longer used. Should be accompanied by a MongoDB migration to clean up old regional analyses. We recently removed a similar worker version related flag from the UI here: conveyal/ui#2064
This will require an additional migration which processes all old regional analyses.
abyrd
reviewed
Mar 5, 2025
| Grid grid = new SelectingGridReducer(cutoffIndex).compute(multiCutoffInputStream); | ||
|
|
||
| File localFile = FileUtils.createScratchFile(fileFormat.toString()); | ||
| FileOutputStream fos = new FileOutputStream(localFile); | ||
| OutputStream fos = FileUtils.getOutputStream(localFile); |
There was a problem hiding this comment.
Looks like some of the methods that take fos as a parameter (at least Grid.write) don't use buffered output streams, so using this utlity method that buffers the output should greatly improve write speeds.
| Grid grid = new SelectingGridReducer(cutoffIndex).compute(multiCutoffInputStream); | ||
|
|
||
| File localFile = FileUtils.createScratchFile(fileFormat.toString()); | ||
| FileOutputStream fos = new FileOutputStream(localFile); | ||
| OutputStream fos = FileUtils.getOutputStream(localFile); | ||
|
|
||
| switch (fileFormat) { |
There was a problem hiding this comment.
This switch is not exhaustive, and when it receives an unexpected value it just falls through without writing anything to the file (or closing it). We should probably convert this to the new exhaustive switch syntax with a default block and no "break".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove old fields in regional analysis that haven't been used in many years.
#957, which contains a MongoDB migration to clean up old regional analyses, should be merged and ideally run first.
We recently removed a similar worker version related flag from the UI here: https://github.com/conveyal/ui/pull/2064