Catch failures to redefine window.ethereum

Author: steveluscher

packages/provider-injection/src/index.ts

@@ -1,13 +1,13 @@
 Object.defineProperty(globalThis, "_backpack_injected_provider", {
   value: true,
-  writable: false
+  writable: false,
 });
 
 import {
-  MOBILE_APP_TRANSPORT_SENDER_EVENTS,
   FromContentScriptTransportSender,
+  MOBILE_APP_TRANSPORT_SENDER_EVENTS,
   ToMobileAppTransportSender,
-} from "@coral-xyz/secure-clients";
+ UserClient } from "@coral-xyz/secure-clients";
 
 // This is a bit of a hack, it's speicifically at the top of this file
 // to ensure it's loaded before other code
@@ -39,6 +39,7 @@ import {
   ProviderRootXnftInjection,
   ProviderSolanaInjection,
 } from "@coral-xyz/provider-core";
+import type { TransportSender } from "@coral-xyz/secure-clients/types";
 import { initialize } from "@coral-xyz/wallet-standard";
 import { v4 as uuidV4 } from "uuid";
 
@@ -47,8 +48,6 @@ import type {
   EIP6963RequestProviderEvent,
   WindowEthereum,
 } from "./types";
-import { TransportSender } from "@coral-xyz/secure-clients/types";
-import { UserClient } from "@coral-xyz/secure-clients";
 
 const logger = getLogger("provider-injection");
 
@@ -124,11 +123,11 @@ function initEthereum(secureClientSender: TransportSender) {
           ...new Set([
             ...(window.ethereum
               ? // Coinbase wallet uses a providers array on window.ethereum, so
-              // include those if already registered
-              Array.isArray(window.ethereum.providers)
+                // include those if already registered
+                Array.isArray(window.ethereum.providers)
                 ? [...window.ethereum.providers, window.ethereum]
                 : // Else just window.ethereum if it is registered
-                [window.ethereum]
+                  [window.ethereum]
               : []),
             backpackEthereum,
           ]),
@@ -158,63 +157,6 @@ function initEthereum(secureClientSender: TransportSender) {
   // If the cached provider changes, we want to change the cached proxy as well
   let cachedCurrentProvider: EIP1193Provider;
 
-  Object.defineProperty(window, "ethereum", {
-    get() {
-      if (!window.walletRouter)
-        throw new Error("Expected window.walletRouter to be set");
-
-      // Provider cache exists
-      if (
-        cachedWindowEthereumProxy &&
-        cachedCurrentProvider === window.walletRouter.currentProvider
-      ) {
-        return cachedWindowEthereumProxy;
-      }
-
-      cachedWindowEthereumProxy = new Proxy(
-        window.walletRouter.currentProvider,
-        {
-          get(target, prop, receiver) {
-            // Sites using web3-react force metamask usage by searching the
-            // providers array, so remove it for specific sites
-            // https://github.com/Uniswap/web3-react/blob/f5a54af645a4a2e125ee2f5ead6dd1ecd5d01dda/packages/metamask/src/index.ts#L56-L59
-            if (
-              window.walletRouter &&
-              !(prop in window.walletRouter.currentProvider) &&
-              prop in window.walletRouter
-            ) {
-              if (
-                window.location.href.endsWith(".app.uniswap.org") ||
-                window.location.href === "app.uniswap.org" ||
-                (
-                  (
-                    window.location.href === "kwenta.io" ||
-                    window.location.href.endsWith(".kwenta.io")
-                  )
-                  && prop === "providers"
-                )
-              ) {
-                return null;
-              }
-              return window.walletRouter[prop];
-            }
-
-            return Reflect.get(target, prop, receiver);
-          },
-        }
-      );
-
-      cachedCurrentProvider = window.walletRouter.currentProvider;
-
-      return cachedWindowEthereumProxy;
-    },
-
-    set(newProvider) {
-      window.walletRouter?.addProvider(newProvider);
-    },
-  });
-
-  // EIP-6963: https://eips.ethereum.org/EIPS/eip-6963
   const info = {
     uuid: uuidV4(),
     name: "Backpack",
@@ -229,8 +171,65 @@ function initEthereum(secureClientSender: TransportSender) {
       })
     );
   }
-  window.addEventListener("eip6963:requestProvider", announceProvider);
-  announceProvider();
+
+  try {
+    Object.defineProperty(window, "ethereum", {
+      get() {
+        if (!window.walletRouter)
+          throw new Error("Expected window.walletRouter to be set");
+
+        // Provider cache exists
+        if (
+          cachedWindowEthereumProxy &&
+          cachedCurrentProvider === window.walletRouter.currentProvider
+        ) {
+          return cachedWindowEthereumProxy;
+        }
+
+        cachedWindowEthereumProxy = new Proxy(
+          window.walletRouter.currentProvider,
+          {
+            get(target, prop, receiver) {
+              // Sites using web3-react force metamask usage by searching the
+              // providers array, so remove it for specific sites
+              // https://github.com/Uniswap/web3-react/blob/f5a54af645a4a2e125ee2f5ead6dd1ecd5d01dda/packages/metamask/src/index.ts#L56-L59
+              if (
+                window.walletRouter &&
+                !(prop in window.walletRouter.currentProvider) &&
+                prop in window.walletRouter
+              ) {
+                if (
+                  window.location.href.endsWith(".app.uniswap.org") ||
+                  window.location.href === "app.uniswap.org" ||
+                  ((window.location.href === "kwenta.io" ||
+                    window.location.href.endsWith(".kwenta.io")) &&
+                    prop === "providers")
+                ) {
+                  return null;
+                }
+                return window.walletRouter[prop];
+              }
+
+              return Reflect.get(target, prop, receiver);
+            },
+          }
+        );
+
+        cachedCurrentProvider = window.walletRouter.currentProvider;
+
+        return cachedWindowEthereumProxy;
+      },
+
+      set(newProvider) {
+        window.walletRouter?.addProvider(newProvider);
+      },
+    });
+
+    window.addEventListener("eip6963:requestProvider", announceProvider);
+    announceProvider();
+  } catch {
+    /* empty */
+  }
 }
 
 main();