Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

"Exposures with low risk on n day(s)" vs "Exposures on n day(s) with increased risk" #578

Closed
Ein-Tim opened this issue Apr 7, 2021 · 8 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement Improvement of an existing feature mirrored-to-jira This item is also tracked internally in JIRA wontfix This will not be worked on

Comments

@Ein-Tim
Copy link
Contributor

Ein-Tim commented Apr 7, 2021

Where to find the issue

Inside of the app on the main risk card, see "Steps to reproduce the issue".

Steps to reproduce the issue

  1. Open the Corona-Warn-App
  2. Get an exposure with low risk
  3. See that the text for a low risk "Exposures with low risk on n day(s)"
  4. Get an exposure with increased risk
  5. See that the text for a increased risk exposure is "Exposures on n day(s) with increased risk"

Describe the issue

The app does not display the number of encounters in the same place for an increased risk encounter (middle of the sentence) as it does for a low risk encounter (end of the sentence).

Suggested change

Let the app display the number of encounters for both, low and increased risk, in the same place of the sentence (either in the middle or on the end).

So either

"Exposures with low risk on n day(s)" &
"Exposures with increased risk on n day(s)"

or

"Exposures on n day(s) with low risk" &
"Exposures on n day(s) with increased risk"

Screenshots

See https://www.coronawarn.app/en/screenshots.


Internal Tracking ID: EXPOSUREAPP-6264

@Ein-Tim Ein-Tim added bug Something isn't working documentation Improvements or additions to documentation labels Apr 7, 2021
@Ein-Tim Ein-Tim changed the title "Exposure with low risk on n day(s)" vs "Exposures on n day(s) with increased risk" "Exposures with low risk on n day(s)" vs "Exposures on n day(s) with increased risk" Apr 7, 2021
@dsarkar dsarkar self-assigned this Apr 8, 2021
@dsarkar dsarkar added the mirrored-to-jira This item is also tracked internally in JIRA label Apr 8, 2021
@dsarkar dsarkar assigned maugst and unassigned dsarkar Apr 8, 2021
@dsarkar dsarkar added enhancement Improvement of an existing feature and removed bug Something isn't working labels Apr 8, 2021
@dsarkar
Copy link
Member

dsarkar commented Apr 8, 2021

@Ein-Tim Thanks. Internal Tracking ID: EXPOSUREAPP-6264

@Ein-Tim
Copy link
Contributor Author

Ein-Tim commented Apr 18, 2022

I provided PR corona-warn-app/cwa-app-ios#4458 addressing this issue.

@dsarkar dsarkar added the wontfix This will not be worked on label Apr 19, 2022
@Ein-Tim
Copy link
Contributor Author

Ein-Tim commented Apr 19, 2022

After I provided PR corona-warn-app/cwa-app-ios#4458 @dsarkar informed me that this is a wont fix. I understand that and this is ok for me, still I'm unhappy about the communication between the team and the community here, see corona-warn-app/cwa-app-ios#4458 (comment).

Closing.

@Ein-Tim Ein-Tim closed this as completed Apr 19, 2022
@dsarkar
Copy link
Member

dsarkar commented Apr 19, 2022

Hi @Ein-Tim, suggestion: in order to avoid working on a PR that might be rejected, you can ping me or another Corona-Warn-App Open Source Team member and we will try to get feedback from the dev team. And as usual, many thanks for contributing here in this project!

@Ein-Tim
Copy link
Contributor Author

Ein-Tim commented Apr 19, 2022

Hey @dsarkar, yes, I will do that in the future, however, issues should not only be rejected when someone wants to work on it but continuously, so that the issue trackers are kept clean and so that the community knows that open issues are valid and can be worked on / are worked on by the team. Do you agree with me here?

@dsarkar
Copy link
Member

dsarkar commented Apr 20, 2022

Hi @Ein-Tim, sure we try to sync as much as possible between the Community and dev team/management/etc... Some issues unfortunately snow under, and only when there is a comment, or in this case a PR, they "awake again to life". This happens particularly with non-critical issues.

@mlenkeit
Copy link
Member

@Ein-Tim for what it's worth, let me elaborate on the wording:

  • Exposures with low risk on n day(s) describes the exposures as being low risk
  • Exposures on n day(s) with increased risk describes the day as having an increased risk

This makes sense, because the risk calculation (1) first distinguishes between exposures as being either low risk or increased risk and then it aggregates the data by date to decide if the day has a low risk or increased risk.

That means there can be a day with increased risk, while all exposures on that day were actually low risk.

This would overlap with Exposures on n day(s) with low risk and exclude Exposures with increased risk on n day(s).

That's why we have the current wording. Apologies for not explaining this earlier.

1 - risk_calculation.svg

@Ein-Tim
Copy link
Contributor Author

Ein-Tim commented Apr 22, 2022

@mlenkeit Thank you very much for the explanation! This makes sense!

That's why we have the current wording. Apologies for not explaining this earlier.

That's absolutely no problem, I understand that the team has a huge workload and that it is nearly impossible to keep up with everything! Have a relaxed evening & weekend!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation enhancement Improvement of an existing feature mirrored-to-jira This item is also tracked internally in JIRA wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

4 participants