Use TestContainers to allow for local testing. #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not compatible with Clusters at this time.
It does not look like a Cluster can be tested with the base image for ArangoDB.
…wn the line. Edit Build.yml to run against 3.11, which was the original tested-against server.
HarryCordewener
commented
Oct 30, 2024
Comment on lines
+72
to
+75
| // This is not yet tested. But is a largely compatible replication of the start_db_cluster script. | ||
| // 2024-10-29 20:11:32 Error while processing command-line options for arangod: | ||
| // 2024 - 10 - 29 20:11:32 unknown option '--cluster.start-dbserver false' | ||
| // I suspect that's because Cluster is only available for Enterprise? |
There was a problem hiding this comment.
Take note of this.
This option is indeed not available in the main image of ArangoDB for arangod.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses TestContainers to create a local ArangoDB Docker Container during the Unit Test run, and then automatically disposes of it afterwards.
This removes the need for the scripts in the docker folder, and allows anyone who has Docker Desktop installed to easily run Unit Tests, and get immediate feedback.
Successful Run on my Remote as well:
https://github.com/harrycordewener/dotnet-arangodb/actions/runs/11585570942/job/32254711741