-
Notifications
You must be signed in to change notification settings - Fork 7
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: add missing links in monorepo tree + cleaning (#1193)
<!-- For Coveo Employees only. Fill this section. CDX-XXX --> ## Proposed changes - Add link from the create-atomic-* packages to their templates - Add link from atomic-component-health-check to create-atomic-* packages - Morph vue to follow the 'defacto' standard. - Replaced `.npmignore` by !-prefixed entry in `files` (because `files` overrule ignore`) - Replaced verbose noop executor by `nx:noop` ## Testing - Run nx graph and check the project graph, and the task graph for `release:phase1` before and after. - Assert that all `create-atomic-*` packages depends (indirectly) on `atomic-component-health-check` - Assert that the CLI depends on all the package it may calls using npx --------- Co-authored-by: ylakhdar <ylakhdar@coveo.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: jpmarceau <39384459+jpmarceau@users.noreply.github.com>
- Loading branch information
1 parent
bfcaf69
commit 34e7b86
Showing
21 changed files
with
107 additions
and
21 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 0 additions & 4 deletions
4
packages/ui/atomic/create-atomic-component-project/.npmignore
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
packages/ui/atomic/create-atomic-component-project/template/project.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
{ | ||
"name": "create-atomic-component-project-template", | ||
"root": "packages/ui/create-atomic-component-project/template", | ||
"sourceRoot": "packages/ui/create-atomic-component-project/template", | ||
"projectType": "library", | ||
"targets": { | ||
"build": { | ||
"executor": "@nrwl/workspace:run-commands", | ||
"options": { | ||
"command": "exit 0" | ||
} | ||
}, | ||
"test": { | ||
"executor": "@nrwl/workspace:run-commands", | ||
"options": { | ||
"command": "exit 0" | ||
} | ||
} | ||
} | ||
} |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
...s/ui/atomic/create-atomic-component/template/src/components/sample-component/project.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
{ | ||
"name": "create-atomic-component-template", | ||
"root": "packages/ui/create-atomic-component/template/src/components/sample-component", | ||
"sourceRoot": "packages/ui/create-atomic-component/template/src/components/sample-component", | ||
"projectType": "library", | ||
"targets": { | ||
"build": { | ||
"executor": "@nrwl/workspace:run-commands", | ||
"options": { | ||
"command": "exit 0" | ||
} | ||
}, | ||
"test": { | ||
"executor": "@nrwl/workspace:run-commands", | ||
"options": { | ||
"command": "exit 0" | ||
} | ||
} | ||
} | ||
} |
4 changes: 0 additions & 4 deletions
4
packages/ui/atomic/create-atomic-component/template/src/html.d.ts
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
...eate-atomic-result-component/template/src/components/sample-result-component/project.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
{ | ||
"name": "create-atomic-result-component-template", | ||
"root": "packages/ui/create-atomic-result-component/template/src/components/sample-result-component", | ||
"sourceRoot": "packages/ui/create-atomic-result-component/template/src/components/sample-result-component", | ||
"projectType": "library", | ||
"targets": { | ||
"build": { | ||
"executor": "@nrwl/workspace:run-commands", | ||
"options": { | ||
"command": "exit 0" | ||
} | ||
}, | ||
"test": { | ||
"executor": "@nrwl/workspace:run-commands", | ||
"options": { | ||
"command": "exit 0" | ||
} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,20 @@ | ||
{ | ||
"ignore": true | ||
"name": "create-headless-vue-template", | ||
"root": "packages/ui/vue/create-headless-vue/template", | ||
"sourceRoot": "packages/ui/vue/create-headless-vue/template", | ||
"projectType": "library", | ||
"targets": { | ||
"build": { | ||
"executor": "@nrwl/workspace:run-commands", | ||
"options": { | ||
"command": "exit 0" | ||
} | ||
}, | ||
"test": { | ||
"executor": "@nrwl/workspace:run-commands", | ||
"options": { | ||
"command": "exit 0" | ||
} | ||
} | ||
} | ||
} |