feat: rewrite selector and add tests

Author: ThibautNazare

packages/headless/src/api/knowledge/stream-answer-api.ts

@@ -1,5 +1,5 @@
 import {createSelector, ThunkDispatch, UnknownAction} from '@reduxjs/toolkit';
-import {selectAdvancedSearchQueries} from '../../features/advanced-search-queries/advanced-query-selectors.js';
+import {selectAdvancedSearchQueries} from '../../features/advanced-search-queries/advanced-search-query-selectors.js';
 import {
   setAnswerContentFormat,
   setCannotAnswer,
@@ -277,10 +277,7 @@ export const constructAnswerQueryParams = (
   usage: 'fetch' | 'select'
 ) => {
   const q = selectQuery(state)?.q;
-  const aq = selectAdvancedSearchQueries(state)?.aq;
-  const cq = selectAdvancedSearchQueries(state)?.cq;
-  const dq = selectAdvancedSearchQueries(state)?.dq;
-  const lq = selectAdvancedSearchQueries(state)?.lq;
+  const advancedQueryParams = selectAdvancedSearchQueries(state) ?? {};
   const searchHub = selectSearchHub(state);
   const pipeline = selectPipeline(state);
   const citationsFieldToInclude = selectFieldsToIncludeInCitation(state) ?? [];
@@ -291,10 +288,7 @@ export const constructAnswerQueryParams = (
 
   return {
     q,
-    aq,
-    cq,
-    dq,
-    lq,
+    ...advancedQueryParams,
     pipelineRuleParameters: {
       mlGenerativeQuestionAnswering: {
         responseFormat: state.generatedAnswer.responseFormat,

packages/headless/src/features/advanced-search-queries/advanced-search-query-selectors.test.ts

@@ -0,0 +1,49 @@
+import {AdvancedSearchQueriesState} from './advanced-search-queries-state.js';
+import {selectAdvancedSearchQueries} from './advanced-search-query-selectors.js';
+
+describe('advancedQuerySearch Selectors test suite', () => {
+  describe('#selectAdvancedSearchQueries', () => {
+    it('should return an empty object when advancedSearchQueries is undefined', () => {
+      const expectedOutput = {};
+      const state = {advancedSearchQueries: undefined};
+
+      const result = selectAdvancedSearchQueries(state);
+
+      expect(result).toEqual(expectedOutput);
+    });
+
+    it('should return only the properties aq, cq, dq, and lq from the state', () => {
+      const exampleAdvancedSearchQueries: AdvancedSearchQueriesState =
+        newExampleAdvancedSearchQueriesStateFixture();
+      const expectedOutput = {
+        aq: 'aq-parameter-value',
+        cq: 'cq-parameter-value',
+        dq: 'dq-parameter-value',
+        lq: 'lq-parameter-value',
+      };
+      const state = {advancedSearchQueries: exampleAdvancedSearchQueries};
+
+      const result = selectAdvancedSearchQueries(state);
+      expect(result).toEqual(expectedOutput);
+    });
+  });
+});
+
+function newExampleAdvancedSearchQueriesStateFixture() {
+  return {
+    aq: 'aq-parameter-value',
+    cq: 'cq-parameter-value',
+    dq: 'dq-parameter-value',
+    lq: 'lq-parameter-value',
+    aqWasSet: true,
+    cqWasSet: false,
+    dqWasSet: false,
+    lqWasSet: true,
+    defaultFilters: {
+      aq: 'a-default-aq-parameter-value',
+      cq: 'a-default-cq-parameter-value',
+      dq: 'a-default-dq-parameter-value',
+      lq: 'a-default-lq-parameter-value',
+    },
+  };
+}

packages/headless/src/features/advanced-search-queries/advanced-query-selectors.ts renamed to packages/headless/src/features/advanced-search-queries/advanced-search-query-selectors.ts

@@ -4,5 +4,11 @@ import {AdvancedSearchQueriesState} from './advanced-search-queries-state.js';
 export const selectAdvancedSearchQueries = createSelector(
   (state: {advancedSearchQueries?: AdvancedSearchQueriesState}) =>
     state.advancedSearchQueries,
-  (advancedSearchQueries) => advancedSearchQueries
+  (advancedSearchQueries) => {
+    if (!advancedSearchQueries) {
+      return {};
+    }
+    const {aq, cq, dq, lq} = advancedSearchQueries;
+    return {aq, cq, dq, lq};
+  }
 );