test(atomic): write unit tests for load more functional button #5001
+72
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexprudhomme
requested review from
olamothe,
fpbrault,
y-lakhdar and
louis-bompart
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
|
alexprudhomme
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
louis-bompart
approved these changes
Feb 24, 2025
There was a problem hiding this comment.
I was unsure about removing the load-more-results as the default value on the first read.
However, I think it might be error-prone to have a default value: If some new developers arrive tomorrow and hafta code something for Commerce, they would copy code from somewhere else in the code base and use the wrong label unbeknownst to them
alexprudhomme
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
alexprudhomme
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
alexprudhomme
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://coveord.atlassian.net/browse/KIT-3991
Was forgotten. Also made it simpler to use.