Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(atomic): generate .tw.css files instead of .css in component generate command #5006

Merged
merged 1 commit into from
Feb 25, 2025
Merged

chore(atomic): generate .tw.css files instead of .css in component generate command #5006

merged 1 commit into from
Feb 25, 2025
+1 −1

Conversation

alexprudhomme
Copy link
Contributor

@alexprudhomme alexprudhomme commented Feb 24, 2025 •
edited
Loading

https://coveord.atlassian.net/browse/KIT-3994

.tw.css is more telling since those file actually use tailwind utilities.

@alexprudhomme alexprudhomme requested a review from a team as a code owner February 24, 2025 15:58
@github-actions GitHub Actions
Copy link

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 243.7 243.7 0
commerce 355 355 0
search 415 415 0
insight 406.2 406.2 0
recommendation 255.9 255.9 0
ssr 408.8 408.8 0
ssr-commerce 372.7 372.7 0

@alexprudhomme alexprudhomme added this pull request to the merge queue Feb 25, 2025
Merged via the queue into master with commit 727a7b9 Feb 25, 2025
96 checks passed
@alexprudhomme alexprudhomme deleted the KIT-3994 branch February 25, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpbrault fpbrault fpbrault approved these changes

@y-lakhdar y-lakhdar y-lakhdar approved these changes

@olamothe olamothe Awaiting requested review from olamothe olamothe is a code owner automatically assigned from coveo/search

@fbeaudoincoveo fbeaudoincoveo Awaiting requested review from fbeaudoincoveo fbeaudoincoveo is a code owner automatically assigned from coveo/search

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexprudhomme @fpbrault @y-lakhdar