Skip to content

chore(atomic): migrate commerce search box components #5152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 11 commits into
base: KIT-4060-2
Choose a base branch
from
Draft

chore(atomic): migrate commerce search box components #5152

wants to merge 11 commits into from

Conversation

alexprudhomme
Copy link
Contributor

https://coveord.atlassian.net/browse/KIT-4060

Migration of the search box components : atomic-commerce-search-box, atomic-commerce-search-box-recent-queries, atomic-commerce-search-box-query-suggestions, atomic-commerce-search-box-instant-products

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2025

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 248.6 248.6 0
commerce 361 361 0
search 419.6 419.6 0
insight 410.8 410.8 0
recommendation 259.5 259.5 0
ssr 413.4 413.4 0
ssr-commerce 377.5 377.5 0

@alexprudhomme alexprudhomme changed the title chore(atomic): migration of commerce search box components chore(atomic): migrate commerce search box components Apr 10, 2025
@alexprudhomme alexprudhomme changed the base branch from KIT-4060-3 to KIT-4060-2 April 10, 2025 13:18
alexprudhomme and others added 7 commits April 10, 2025 09:18
alexprudhomme
alexprudhomme commented Apr 10, 2025
View reviewed changes
...ages/atomic/src/components/commerce/atomic-commerce-search-box/atomic-commerce-search-box.ts
Comment on lines +127 to +132
this.addEventListener('atomic/selectChildProduct', (event: Event) => {
const customEvent = event as CustomEvent<SelectChildProductEventArgs>;
customEvent.stopPropagation();
this.bindings.store.state.activeProductChild = customEvent.detail.child;
this.suggestionManager.forceUpdate();
});
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • remove event listeners in the disconnectedCallback()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alexprudhomme