Skip to content

fix(headless): advanced search queries parameters are not passed along #5173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/headless/src/api/knowledge/stream-answer-api.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import {createSelector, ThunkDispatch, UnknownAction} from '@reduxjs/toolkit';
import {selectAdvancedSearchQueries} from '../../features/advanced-search-queries/advanced-search-query-selectors.js';
import {
setAnswerContentFormat,
setCannotAnswer,
Expand Down Expand Up @@ -276,6 +277,7 @@ export const constructAnswerQueryParams = (
usage: 'fetch' | 'select'
) => {
const q = selectQuery(state)?.q;
const advancedQueryParams = selectAdvancedSearchQueries(state) ?? {};
const searchHub = selectSearchHub(state);
const pipeline = selectPipeline(state);
const citationsFieldToInclude = selectFieldsToIncludeInCitation(state) ?? [];
Expand All @@ -286,6 +288,7 @@ export const constructAnswerQueryParams = (

return {
q,
...advancedQueryParams,
pipelineRuleParameters: {
mlGenerativeQuestionAnswering: {
responseFormat: state.generatedAnswer.responseFormat,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,22 @@ export const streamAnswerAPIStateMock: StateNeededByAnswerAPI = {
q: 'what is the hardest wood',
enableQuerySyntax: false,
},
advancedSearchQueries: {
aq: 'aq-test-query',
aqWasSet: true,
cq: 'cq-test-query',
cqWasSet: true,
dq: 'dq-test-query',
dqWasSet: true,
lq: 'lq-test-query',
lqWasSet: true,
defaultFilters: {
cq: '',
aq: '',
lq: '',
dq: '',
},
},
querySuggest: {},
querySet: {
'atomic-search-box-ie7ah': 'what is the hardest wood',
Expand Down Expand Up @@ -1056,6 +1072,10 @@ export const streamAnswerAPIStateMock: StateNeededByAnswerAPI = {

export const expectedStreamAnswerAPIParam = {
q: 'what is the hardest wood',
aq: 'aq-test-query',
cq: 'cq-test-query',
dq: 'dq-test-query',
lq: 'lq-test-query',
pipelineRuleParameters: {
mlGenerativeQuestionAnswering: {
responseFormat: {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
import {AdvancedSearchQueriesState} from './advanced-search-queries-state.js';
import {selectAdvancedSearchQueries} from './advanced-search-query-selectors.js';

describe('advancedQuerySearch Selectors test suite', () => {
describe('#selectAdvancedSearchQueries', () => {
it('should return an empty object when advancedSearchQueries is undefined', () => {
const expectedOutput = {};
const state = {advancedSearchQueries: undefined};

const result = selectAdvancedSearchQueries(state);

expect(result).toEqual(expectedOutput);
});

it('should return only the properties aq, cq, dq, and lq from the state', () => {
const exampleAdvancedSearchQueries: AdvancedSearchQueriesState =
newExampleAdvancedSearchQueriesStateFixture();
const expectedOutput = {
aq: 'aq-parameter-value',
cq: 'cq-parameter-value',
dq: 'dq-parameter-value',
lq: 'lq-parameter-value',
};
const state = {advancedSearchQueries: exampleAdvancedSearchQueries};

const result = selectAdvancedSearchQueries(state);
expect(result).toEqual(expectedOutput);
});
});
});

function newExampleAdvancedSearchQueriesStateFixture() {
return {
aq: 'aq-parameter-value',
cq: 'cq-parameter-value',
dq: 'dq-parameter-value',
lq: 'lq-parameter-value',
aqWasSet: true,
cqWasSet: false,
dqWasSet: false,
lqWasSet: true,
defaultFilters: {
aq: 'a-default-aq-parameter-value',
cq: 'a-default-cq-parameter-value',
dq: 'a-default-dq-parameter-value',
lq: 'a-default-lq-parameter-value',
},
};
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
import {createSelector} from '@reduxjs/toolkit';
import {AdvancedSearchQueriesState} from './advanced-search-queries-state.js';

export const selectAdvancedSearchQueries = createSelector(
(state: {advancedSearchQueries?: AdvancedSearchQueriesState}) =>
state.advancedSearchQueries,
(advancedSearchQueries) => {
if (!advancedSearchQueries) {
return {};
}
const {aq, cq, dq, lq} = advancedSearchQueries;
return {aq, cq, dq, lq};
}
);
Loading