Skip to content

chore(atomic): migrate atomic-commerce-recommendation-interface to Lit #5174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 16 commits into
base: KIT-3932
Choose a base branch
from

Conversation

fpbrault
Copy link
Contributor

@fpbrault fpbrault commented Apr 14, 2025

[Component Name] Component Specification

📝 Requirements

The [component-name] component is designed to [brief description of the component's purpose].

  • [Requirement 1]: [Brief description of the first requirement]
  • [Requirement 2]: [Brief description of the second requirement]

♿ Accessibility

  • [Description of accessibility considerations, such as ARIA roles, keyboard navigation, etc.]

⚡ Performance & Security (if applicable)

  • [Description of performance considerations, such as asynchronous operations, lazy loading, etc.]
  • [Description of security considerations, such as sanitization, preventing XSS attacks, etc.]

⚠️ Risks and Challenges (if applicable)

  • [Risk or challenge 1]
  • [Risk or challenge 2]

✅ Checklist

  • 🧪 The component is unit tested
  • 🧪 The component includes E2E tests
  • 🗑️ Old Cypress tests exclusive to the component are removed
  • 📖 The component is documented in storybook with an .mdx file
  • ♿ The component complies with the Web Content Accessibility Guidelines.
  • 🌐 All strings intended for humans or assistive technology must be localized with i18n.
  • 📦 The Lit component is exported in the appropriate index.ts and lazy-index.ts files.
  • 🎨 CSS parts are documented still accessible.
  • 🦥 Slotted Content, public methods and properties are documented
  • 🔄 The component outputs the same Angular output as before with Stencil
  • 🏷️ The component declares the component type in the HTMLElementTagNameMap

https://coveord.atlassian.net/browse/KIT-[____]

@developer-experience-bot
Copy link
Contributor

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 248.6 248.6 0
commerce 361 361 0
search 419.6 419.6 0
insight 410.8 410.8 0
recommendation 259.5 259.5 0
ssr 413.4 413.4 0
ssr-commerce 377.5 377.5 0

@fpbrault fpbrault changed the title chore(atomic): migrate atomic-commerce-interface to Lit chore(atomic): migrate atomic-commerce-recommendation-interface to Lit Apr 14, 2025
fpbrault and others added 14 commits April 14, 2025 10:15
https://coveord.atlassian.net/browse/KIT-3932

use non-stencil getAssetPath

https://coveord.atlassian.net/browse/KIT-3932

remove log

https://coveord.atlassian.net/browse/KIT-3932

smaller styles

https://coveord.atlassian.net/browse/KIT-3932

remove unused styles

https://coveord.atlassian.net/browse/KIT-3932

add missing generated files

https://coveord.atlassian.net/browse/KIT-3932

fix build

https://coveord.atlassian.net/browse/KIT-3932

cleanup

https://coveord.atlassian.net/browse/KIT-3932

other approach for loader

https://coveord.atlassian.net/browse/KIT-3932

cleanup

https://coveord.atlassian.net/browse/KIT-3932

create bindings decorator

https://coveord.atlassian.net/browse/KIT-4005

fix bindings

https://coveord.atlassian.net/browse/KIT-4005

add commerce page to angular sample

https://coveord.atlassian.net/browse/KIT-3932

fix interface init

https://coveord.atlassian.net/browse/KIT-3932

revert setup

https://coveord.atlassian.net/browse/KIT-3932

revert loader change

https://coveord.atlassian.net/browse/KIT-3932

restore coveoglobal for lit interface

https://coveord.atlassian.net/browse/KIT-3932

fix init

https://coveord.atlassian.net/browse/KIT-3932

fix story

https://coveord.atlassian.net/browse/KIT-3932

fix missing global version

https://coveord.atlassian.net/browse/KIT-3932

cleanup

https://coveord.atlassian.net/browse/KIT-3932

fix cdn build

https://coveord.atlassian.net/browse/KIT-3932

fix components

https://coveord.atlassian.net/browse/KIT-3932

fix build

https://coveord.atlassian.net/browse/KIT-3932

add commerce angular smoke test

https://coveord.atlassian.net/browse/KIT-3932

fix unit tests

https://coveord.atlassian.net/browse/KIT-3932

lint fix

https://coveord.atlassian.net/browse/KIT-3932

fallback to ts if no tsx exists

https://coveord.atlassian.net/browse/KIT-3932

fix test generation

https://coveord.atlassian.net/browse/KIT-3932

fix interface

https://coveord.atlassian.net/browse/KIT-3932

fix for storybook?

https://coveord.atlassian.net/browse/KIT-3932

move initAriaLive to connectedCallback

https://coveord.atlassian.net/browse/KIT-3932

restore e2e tests

https://coveord.atlassian.net/browse/KIT-3932

add arbitrary delay before first request for storybook

https://coveord.atlassian.net/browse/KIT-3932

remove withresolvers

https://coveord.atlassian.net/browse/KIT-3932

remove cspnonce

https://coveord.atlassian.net/browse/KIT-3932

Add generated files

add atomic-commerce-url-manager

https://coveord.atlassian.net/browse/KIT-3932

fix tests

https://coveord.atlassian.net/browse/KIT-3932

handle region locale

https://coveord.atlassian.net/browse/KIT-3932

different approach for url manager

https://coveord.atlassian.net/browse/KIT-3932

add ChildrenUpdateCompleteMixin mixin

https://coveord.atlassian.net/browse/KIT-4073

use ChildrenUpdateCompleteMixin

https://coveord.atlassian.net/browse/KIT-3932

fix mixin

https://coveord.atlassian.net/browse/KIT-3932

fix test

https://coveord.atlassian.net/browse/KIT-3932

remove timeouts

https://coveord.atlassian.net/browse/KIT-3932
Signed-off-by: Felix Perron-Brault <fpbrault@coveo.com>
https://coveord.atlassian.net/browse/KIT-3932
Signed-off-by: Felix Perron-Brault <fpbrault@coveo.com>
https://coveord.atlassian.net/browse/KIT-3932
Signed-off-by: Felix Perron-Brault <fpbrault@coveo.com>

add generated files

https://coveord.atlassian.net/browse/KIT-3932
Signed-off-by: Felix Perron-Brault <fpbrault@coveo.com>
@fpbrault fpbrault changed the base branch from KIT-3937 to master April 14, 2025 17:40
@fpbrault fpbrault changed the base branch from master to KIT-3932 April 14, 2025 17:40
@fpbrault fpbrault force-pushed the KIT-3932 branch 5 times, most recently from 15ae410 to 290784d Compare April 22, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants