-
Notifications
You must be signed in to change notification settings - Fork 36
feat(quantic): quantic insight summary component created #5185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
|
...tic/force-app/main/default/lwc/quanticInsightSummary/__tests__/quanticInsightSummary.test.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 test is empty, but the rest looks good GG
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really small changes, but otherwise nice!
packages/quantic/force-app/main/default/lwc/quanticInsightSummary/quanticInsightSummary.css
Show resolved
Hide resolved
@@ -884,4 +884,8 @@ | |||
<label>Fermer la notification</label> | |||
<name>quantic_CloseNotification</name> | |||
</customLabels> | |||
<customLabels> | |||
<label>Perspectives liées à ce cas</label> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that really the correct word we want to use?
"Contenu recommandé pour ce cas"?
"Contenu relié à ce cas"?
"Ressources pertinentes pour ce cas"?
"Ressources liées à ce cas"?
Perspectives n'est pas vraiment une traduction de "Insights" dans ce contexte.
The above suggestions are recommendations from chat-gpt :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will update to Contenu recommandé pour ce cas
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didnt mind the perspectives
imo contenu is more like content
than insights
maybe we could confirm what @acarpentier01 thinks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes contenu
is more like content
than insights
, but our component offers content
and also potentially insights about the previously consulted documents by the creator of the case.
Definitely not "perspectives" :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My preference is "Ressources pertinentes pour ce cas" @mmitiche.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like Ressources yeah!
SFINT-6112
Insight related to this case
when no query is executed and the normal query summary when a query is executed in the insight panel use case..