Skip to content

feat(quantic): quantic insight summary component created #5185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mmitiche
Copy link
Contributor

@mmitiche mmitiche commented Apr 18, 2025

SFINT-6112

  • Create Quantic Insight Summary component.
  • Added unit tests to cover the logic of this component.
  • The Quantic Insight Summary displays the message Insight related to this case when no query is executed and the normal query summary when a query is executed in the insight panel use case..
Screenshot 2025-04-10 at 9 40 36 AM

@mmitiche mmitiche requested a review from a team as a code owner April 18, 2025 10:33
@mmitiche mmitiche requested a review from mikegron April 18, 2025 10:33
@developer-experience-bot
Copy link
Contributor

developer-experience-bot bot commented Apr 18, 2025

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 248.8 248.8 0
commerce 361.1 361.1 0
search 419.8 419.8 0
insight 410.9 410.9 0
recommendation 259.6 259.6 0
ssr 413.5 413.5 0
ssr-commerce 377.6 377.6 0

Copy link
Contributor

@SimonMilord SimonMilord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 test is empty, but the rest looks good GG

Copy link
Collaborator

@erocheleau erocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really small changes, but otherwise nice!

@@ -884,4 +884,8 @@
<label>Fermer la notification</label>
<name>quantic_CloseNotification</name>
</customLabels>
<customLabels>
<label>Perspectives liées à ce cas</label>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that really the correct word we want to use?

"Contenu recommandé pour ce cas"?
"Contenu relié à ce cas"?
"Ressources pertinentes pour ce cas"?
"Ressources liées à ce cas"?

Perspectives n'est pas vraiment une traduction de "Insights" dans ce contexte.
The above suggestions are recommendations from chat-gpt :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will update to Contenu recommandé pour ce cas 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didnt mind the perspectives imo contenu is more like content than insights maybe we could confirm what @acarpentier01 thinks

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes contenu is more like content than insights, but our component offers content and also potentially insights about the previously consulted documents by the creator of the case.

Definitely not "perspectives" :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My preference is "Ressources pertinentes pour ce cas" @mmitiche.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like Ressources yeah!

@mmitiche mmitiche added this pull request to the merge queue Apr 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 23, 2025
@mmitiche mmitiche added this pull request to the merge queue Apr 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants