-
Notifications
You must be signed in to change notification settings - Fork 671
Collapsible source headings #17226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 5.8
Are you sure you want to change the base?
Collapsible source headings #17226
Conversation
Related issues: |
…ollapsible-index-headings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!! Couple thoughts:
- The setting seems unnecessary? From an AX perspective it would be weird if some headings are collapsible and some aren’t.
- I don’t love the collapsed toggle styling’s inverted colors. Let’s just have it look the same, but upside-down, as when the heading is expanded.
# Conflicts: # src/web/assets/cp/dist/cp.js # src/web/assets/cp/dist/cp.js.map
…com:craftcms/cms into feature/CMS-1339-collapsible-index-headings
Updated, all headings are just collapsible now.
The toggle will only appear this way when one of the items nested beneath it (and therefore invisible when collapsed) is selected. The goal was to provide some kind of "hey a thing under here is selected" indicator. We could also highlight the actual item that's collapsed, but that felt a little too strong to me. I also remove these lines because a heading will always get a |
Description
Adds a "collapsible" option to source headings when customizing.
When checked, headings will get an icon before the label and items beneath the heading can be collapsed.
If the current page is an ancestor of a collapsed section, the icon will flip colors to denote a collapsed item is active.
The state of each toggle will be stored in cookies so it will persist across page loads. The only downside is a minor flash of the expanded state.
Related issues
Fixes CMS-1339