Skip to content

changed entry type and the modified indicators #17242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: 5.x
Choose a base branch
from

Conversation

i-just
Copy link
Contributor

@i-just i-just commented May 8, 2025

Description

Steps to reproduce:

  • create an entry type et1 with a plain text field in it
  • create a second entry type et2 with a matrix field (in any view mode) in it
  • create a section with both entry types, make sure the et1 is the first on the list
  • create a new entry in that section (don’t save)
  • switch entry type to et2
  • click “New entry” to add a new nested entry to the matrix field
  • note that the blue modified indicator doesn’t show for the matrix field

If you were to reload the page after switching the entry type, the indicators would show as expected.

This PR fixes the issue by allowing the delta names to get registered when the entry type is changed and updating the data-delta-names on the main-form container.

Related issues

n/a

@i-just i-just marked this pull request as draft May 8, 2025 16:51
@i-just i-just closed this May 12, 2025
@i-just i-just reopened this May 12, 2025
@i-just i-just marked this pull request as ready for review May 12, 2025 15:05
@i-just i-just requested a review from brandonkelly May 12, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant