Skip to content

Commit 98554a5

Browse files
committed
Fix unit tests and re-use existing logic for setting remote model
1 parent c74689d commit 98554a5

File tree

1 file changed

+20
-20
lines changed

1 file changed

+20
-20
lines changed

test/ir_Toshiba_test.cpp

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -311,22 +311,22 @@ TEST(TestToshibaACClass, HumanReadableOutput) {
311311
0x00, 0xC1, 0x00, 0xC0};
312312

313313
ac.setRaw(initial_state);
314-
EXPECT_EQ("Temp: 17C, Power: On, Mode: 0 (Auto), Fan: 0 (Auto), "
315-
"Turbo: Off, Econo: Off, Filter: Off",
314+
EXPECT_EQ("Model: 0 (TOSHIBA REMOTE A), Temp: 17C, Power: On, Mode: 0 (Auto), "
315+
"Fan: 0 (Auto), Turbo: Off, Econo: Off, Filter: Off",
316316
ac.toString());
317317
ac.setRaw(modified_state);
318-
EXPECT_EQ("Temp: 17C, Power: On, Mode: 1 (Cool), Fan: 5 (High), "
319-
"Turbo: Off, Econo: Off, Filter: Off",
318+
EXPECT_EQ("Model: 0 (TOSHIBA REMOTE A), Temp: 17C, Power: On, Mode: 1 (Cool), "
319+
"Fan: 5 (High), Turbo: Off, Econo: Off, Filter: Off",
320320
ac.toString());
321321
ac.setTemp(25);
322322
ac.setFan(3);
323323
ac.setMode(kToshibaAcDry);
324-
EXPECT_EQ("Temp: 25C, Power: On, Mode: 2 (Dry), Fan: 3 (Medium), "
325-
"Turbo: Off, Econo: Off, Filter: Off",
324+
EXPECT_EQ("Model: 0 (TOSHIBA REMOTE A), Temp: 25C, Power: On, Mode: 2 (Dry), "
325+
"Fan: 3 (Medium), Turbo: Off, Econo: Off, Filter: Off",
326326
ac.toString());
327327
ac.off();
328-
EXPECT_EQ("Temp: 25C, Power: Off, Fan: 3 (Medium), Turbo: Off, Econo: Off, "
329-
"Filter: Off",
328+
EXPECT_EQ("Model: 0 (TOSHIBA REMOTE A), Temp: 25C, Power: Off, Fan: 3 (Medium), "
329+
"Turbo: Off, Econo: Off, Filter: Off",
330330
ac.toString());
331331
}
332332

@@ -379,8 +379,8 @@ TEST(TestDecodeToshibaAC, SyntheticExample) {
379379
ASSERT_EQ(kToshibaACBits, irsend.capture.bits);
380380
EXPECT_STATE_EQ(expectedState, irsend.capture.state, irsend.capture.bits);
381381
EXPECT_EQ(
382-
"Temp: 17C, Power: On, Mode: 0 (Auto), Fan: 0 (Auto), Turbo: Off, "
383-
"Econo: Off, Filter: Off",
382+
"Model: 0 (TOSHIBA REMOTE A), Temp: 17C, Power: On, Mode: 0 (Auto), "
383+
"Fan: 0 (Auto), Turbo: Off, Econo: Off, Filter: Off",
384384
IRAcUtils::resultAcToString(&irsend.capture));
385385
stdAc::state_t r, p;
386386
ASSERT_TRUE(IRAcUtils::decodeToState(&irsend.capture, &r, &p));
@@ -627,8 +627,8 @@ TEST(TestDecodeToshibaAC, RealLongExample) {
627627
EXPECT_EQ(kToshibaACBitsLong, irsend.capture.bits);
628628
EXPECT_STATE_EQ(expectedState, irsend.capture.state, irsend.capture.bits);
629629
EXPECT_EQ(
630-
"Temp: 22C, Power: On, Mode: 0 (Auto), Fan: 0 (Auto), Turbo: On, "
631-
"Econo: Off, Filter: Off",
630+
"Model: 0 (TOSHIBA REMOTE A), Temp: 22C, Power: On, Mode: 0 (Auto), "
631+
"Fan: 0 (Auto), Turbo: On, Econo: Off, Filter: Off",
632632
IRAcUtils::resultAcToString(&irsend.capture));
633633
}
634634

@@ -718,7 +718,7 @@ TEST(TestDecodeToshibaAC, RealShortExample) {
718718
EXPECT_EQ(kToshibaACBitsShort, irsend.capture.bits);
719719
EXPECT_STATE_EQ(expectedState, irsend.capture.state, irsend.capture.bits);
720720
EXPECT_EQ(
721-
"Temp: 17C, Swing(V): 0 (Step)",
721+
"Model: 0 (TOSHIBA REMOTE A), Temp: 17C, Swing(V): 0 (Step)",
722722
IRAcUtils::resultAcToString(&irsend.capture));
723723
}
724724

@@ -732,8 +732,8 @@ TEST(TestToshibaACClass, ConstructLongState) {
732732
ac.setTurbo(false);
733733
ac.setEcono(true);
734734
EXPECT_EQ(
735-
"Temp: 29C, Power: On, Mode: 2 (Dry), Fan: 2 (UNKNOWN), "
736-
"Turbo: Off, Econo: On, Filter: Off",
735+
"Model: 0 (TOSHIBA REMOTE A), Temp: 29C, Power: On, Mode: 2 (Dry), "
736+
"Fan: 2 (UNKNOWN), Turbo: Off, Econo: On, Filter: Off",
737737
ac.toString());
738738
EXPECT_EQ(kToshibaACStateLengthLong, ac.getStateLength());
739739
const uint8_t expectedState[kToshibaACStateLengthLong] = {
@@ -783,8 +783,8 @@ TEST(TestDecodeToshibaAC, RealExample_WHUB03NJ) {
783783
EXPECT_EQ(kToshibaACBits, irsend.capture.bits);
784784
EXPECT_STATE_EQ(expectedState, irsend.capture.state, irsend.capture.bits);
785785
EXPECT_EQ(
786-
"Temp: 20C, Power: Off, Fan: 0 (Auto), Turbo: Off, Econo: Off, "
787-
"Filter: Off",
786+
"Model: 0 (TOSHIBA REMOTE A), Temp: 20C, Power: Off, Fan: 0 (Auto), "
787+
"Turbo: Off, Econo: Off, Filter: Off",
788788
IRAcUtils::resultAcToString(&irsend.capture));
789789
}
790790

@@ -805,7 +805,7 @@ TEST(TestToshibaACClass, SwingCodes) {
805805
ac.setSwing(kToshibaAcSwingOn);
806806

807807
EXPECT_EQ(
808-
"Temp: 17C, Swing(V): 1 (On)",
808+
"Model: 0 (TOSHIBA REMOTE A), Temp: 17C, Swing(V): 1 (On)",
809809
ac.toString());
810810
EXPECT_EQ(kToshibaACStateLengthShort, ac.getStateLength());
811811
const uint8_t swingOnState[kToshibaACStateLengthShort] = {
@@ -815,7 +815,7 @@ TEST(TestToshibaACClass, SwingCodes) {
815815

816816
ac.setSwing(kToshibaAcSwingOff);
817817
EXPECT_EQ(
818-
"Temp: 17C, Swing(V): 2 (Off)",
818+
"Model: 0 (TOSHIBA REMOTE A), Temp: 17C, Swing(V): 2 (Off)",
819819
ac.toString());
820820
EXPECT_EQ(kToshibaACStateLengthShort, ac.getStateLength());
821821
const uint8_t swingOffState[kToshibaACStateLengthShort] = {
@@ -828,7 +828,7 @@ TEST(TestToshibaACClass, SwingCodes) {
828828
ac.setRaw(swingToggleState, kToshibaACStateLengthShort);
829829
EXPECT_EQ(kToshibaAcSwingToggle, ac.getSwing());
830830
EXPECT_EQ(
831-
"Temp: 17C, Swing(V): 4 (Toggle)",
831+
"Model: 0 (TOSHIBA REMOTE A), Temp: 17C, Swing(V): 4 (Toggle)",
832832
ac.toString());
833833
}
834834

0 commit comments

Comments
 (0)