chore: fix clippy (#109)

* make rust infer the types

* fix clippy

Author: kevaundray

bindings/java/rust_code/src/errors.rs

@@ -1,4 +1,4 @@
-use rust_eth_kzg::Error as DASError;
+use rust_eth_kzg::Error as KZGError;
 
 #[derive(Debug)]
 pub enum Error {
@@ -8,7 +8,7 @@ pub enum Error {
         got: usize,
         name: &'static str,
     },
-    DASError(DASError),
+    Cryptography(KZGError),
 }
 
 impl From<jni::errors::Error> for Error {
@@ -17,8 +17,8 @@ impl From<jni::errors::Error> for Error {
     }
 }
 
-impl From<DASError> for Error {
-    fn from(err: DASError) -> Self {
-        Error::DASError(err)
+impl From<KZGError> for Error {
+    fn from(err: KZGError) -> Self {
+        Error::Cryptography(err)
     }
 }

bindings/java/rust_code/src/lib.rs

@@ -149,7 +149,7 @@ fn verify_cell_kzg_proof_batch<'local>(
     ) {
         Ok(_) => Ok(jboolean::from(true)),
         Err(x) if x.invalid_proof() => Ok(jboolean::from(false)),
-        Err(err) => Err(Error::DASError(err)),
+        Err(err) => Err(Error::Cryptography(err)),
     }
 }
 
@@ -291,7 +291,7 @@ fn throw_on_error(env: &mut JNIEnv, err: Error, func_name: &'static str) {
             got,
             name,
         } => format!("{name} is not the correct size. expected: {expected}\ngot: {got}"),
-        Error::DASError(err) => format!("{:?}", err),
+        Error::Cryptography(err) => format!("{:?}", err),
     };
     let msg = format!(
         "function {} has thrown an exception, with reason: {}",

cryptography/kzg_multi_open/src/fk20/verifier.rs

@@ -192,6 +192,7 @@ impl FK20Verifier {
 /// Efficiently refers to being able to verify these proofs faster than verifying each proof individually.
 ///
 /// The matching function in the spec is: https://github.com/ethereum/consensus-specs/blob/b9e7b031b5f2c18d76143007ea779a32b5505155/specs/_features/eip7594/polynomial-commitments-sampling.md#compute_verify_cell_kzg_proof_batch_challenge
+#[allow(clippy::manual_slice_size_calculation)]
 fn compute_fiat_shamir_challenge(
     opening_key: &OpeningKey,
     row_commitments: &[G1Point],

eip7594/src/serialization.rs

@@ -45,10 +45,10 @@ pub(crate) fn deserialize_cell_to_scalars(
 }
 
 pub(crate) fn deserialize_scalar(scalar_bytes: &[u8]) -> Result<Scalar, SerializationError> {
-    let bytes32 : [u8;BYTES_PER_FIELD_ELEMENT]= scalar_bytes.try_into().expect("infallible: expected blob chunks to be exactly {SCALAR_SERIALIZED_SIZE} bytes, since blob was a multiple of {SCALAR_SERIALIZED_SIZE");
+    let bytes32 = scalar_bytes.try_into().expect("infallible: expected blob chunks to be exactly {SCALAR_SERIALIZED_SIZE} bytes, since blob was a multiple of {SCALAR_SERIALIZED_SIZE");
 
     // Convert the CtOption into Option
-    let option_scalar: Option<Scalar> = Scalar::from_bytes_be(&bytes32).into();
+    let option_scalar: Option<Scalar> = Scalar::from_bytes_be(bytes32).into();
     match option_scalar {
         Some(scalar) => Ok(scalar),
         None => Err(SerializationError::CouldNotDeserializeScalar {
@@ -58,7 +58,7 @@ pub(crate) fn deserialize_scalar(scalar_bytes: &[u8]) -> Result<Scalar, Serializ
 }
 
 pub(crate) fn deserialize_compressed_g1(point_bytes: &[u8]) -> Result<G1Point, SerializationError> {
-    let point_bytes: [u8; BYTES_PER_G1_POINT] = match point_bytes.try_into() {
+    let point_bytes = match point_bytes.try_into() {
         Ok(bytes) => bytes,
         Err(_) => {
             return Err(SerializationError::G1PointHasInvalidLength {
@@ -68,7 +68,7 @@ pub(crate) fn deserialize_compressed_g1(point_bytes: &[u8]) -> Result<G1Point, S
         }
     };
 
-    let opt_g1: Option<G1Point> = Option::from(G1Point::from_compressed(&point_bytes));
+    let opt_g1: Option<G1Point> = Option::from(G1Point::from_compressed(point_bytes));
     opt_g1.ok_or(SerializationError::CouldNotDeserializeG1Point {
         bytes: point_bytes.to_vec(),
     })