Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to load CreateThis_VRTK_GrabAttach and CreateThis_VRTK_Interactable #20

Open
noorbeast opened this issue Jul 18, 2017 · 6 comments

Comments

@noorbeast
Copy link

Unity 2017.1.0f3

SteamVR 1.2.2

VRTK 3.2.1

Fails to load CreateThis_VRTK_GrabAttach and CreateThis_VRTK_Interactable

Panel -> The associated script can not be loaded. Please fix any compile errors and assign a valid script.

@createthis
Copy link
Owner

What is the actual compile error? I think this is the result of the compile error not the error itself.

@noorbeast
Copy link
Author

noorbeast commented Jul 18, 2017

There is no compile error, the scripts just fail to load with the reported message against the panel object.

I think there are update changes to VRTK.

@createthis
Copy link
Owner

Do you have VRTK set per the Platform Custom Defines section in the README? Working fine without VRTK with 2017.1 and SteamVR 1.2.2 on my end.

Those scripts are right here and are pretty straight forward: https://github.com/createthis/createthis_vr_ui/blob/master/Assets/CreateThis/Scripts/VRTK/CreateThis_VRTK_GrabAttach.cs

I also wonder if this could be a case where Library needs to be deleted and rebuilt as Unity has some other version of the code cached.

@noorbeast
Copy link
Author

noorbeast commented Jul 18, 2017

Yes ;VRTK is set per the Platform Custom Defines.

Yes it is working fine for me also in 2017.1.0f3 and SteamVR 1.2.2 without VRTK.

I am not keen on messing with deleting the Library so tried it with 5.6.2f1 on a different machine and got the same notification against the Panel, but no actual compile error.

I can't force an error with either the Asset Store or GitHub versions of VRTK, but it does throw the following errors if I use the VRTK-release-3.3.0-alpha:

Assets/CreateThis/Scripts/VRTK/CreateThis_VRTK_Interactable.cs(10,30): error CS0115: `CreateThis.VRTK.CreateThis_VRTK_Interactable.StartTouching(UnityEngine.GameObject)' is marked as an override but no suitable method found to override

Assets/CreateThis/Scripts/VRTK/CreateThis_VRTK_Interactable.cs(21,30): error CS0115: `CreateThis.VRTK.CreateThis_VRTK_Interactable.StopTouching(UnityEngine.GameObject)' is marked as an override but no suitable method found to override

@noorbeast
Copy link
Author

I downloaded the commit update to 2017 you just made today, started from scratch and noted the following when using the Asset store version of VRTK:

Assets/CreateThis/Scripts/VRTK/CreateThis_VRTK_Interactable.cs(10,30): warning CS0672: Member CreateThis.VRTK.CreateThis_VRTK_Interactable.StartTouching(UnityEngine.GameObject)' overrides obsolete member VRTK.VRTK_InteractableObject.StartTouching(UnityEngine.GameObject)'. Add the Obsolete attribute to `CreateThis.VRTK.CreateThis_VRTK_Interactable.StartTouching(UnityEngine.GameObject)'

Assets/CreateThis/Scripts/VRTK/CreateThis_VRTK_Interactable.cs(21,30): warning CS0672: Member CreateThis.VRTK.CreateThis_VRTK_Interactable.StopTouching(UnityEngine.GameObject)' overrides obsolete member VRTK.VRTK_InteractableObject.StopTouching(UnityEngine.GameObject)'. Add the Obsolete attribute to `CreateThis.VRTK.CreateThis_VRTK_Interactable.StopTouching(UnityEngine.GameObject)'

Assets/CreateThis/Scripts/VRTK/CreateThis_VRTK_Interactable.cs(11,18): warning CS0618: VRTK.VRTK_InteractableObject.StartTouching(UnityEngine.GameObject)' is obsolete: ``VRTK_InteractableObject.StartTouching(GameObject currentTouchingObject) has been replaced with VRTK_InteractableObject.StartTouching(VRTK_InteractTouch currentTouchingObject). This method will be removed in a future version of VRTK.'

Assets/CreateThis/Scripts/VRTK/CreateThis_VRTK_Interactable.cs(22,18): warning CS0618: VRTK.VRTK_InteractableObject.StopTouching(UnityEngine.GameObject)' is obsolete: ``VRTK_InteractableObject.StopTouching(GameObject previousTouchingObject) has been replaced with VRTK_InteractableObject.StopTouching(VRTK_InteractTouch previousTouchingObject). This method will be removed in a future version of VRTK.'

@createthis
Copy link
Owner

Is it an easy refactor? replace GameObject with VRTK_InteractTouch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants