Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve multi-author support with specific image for multiple authors #768

Closed
wants to merge 0 commits into from

Conversation

Kirsty21
Copy link
Contributor

@Kirsty21 Kirsty21 commented Mar 8, 2024

Fixes

Description

This PR adjusts the macro of files authors_gravatar.html and posts.html so, whenever a post has multiple authors an image that is chosen to represent multiple authors instead. The gravatar for all other single author posts remains the same (according to their email addresses)

Technical details

If statements that takes the length of post.author and checks whether the number of authors is above or equal to 1

Screenshots

Before:

image

After:

image image

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Kirsty21 Kirsty21 requested review from a team as code owners March 8, 2024 21:46
@Kirsty21 Kirsty21 requested review from Shafiya-Heena, possumbilities and akmadian and removed request for a team March 8, 2024 21:46
@Kirsty21

This comment was marked as outdated.

Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! there are a few requested changes

@TimidRobot TimidRobot self-assigned this Apr 1, 2024
@Kirsty21

This comment was marked as outdated.

@Kirsty21 Kirsty21 requested a review from TimidRobot April 5, 2024 12:13
Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! there are a few requested changes

Comment on lines 7 to 18
{% if post.author|length >= 2 %}

<header>
<figure class="image blog-image">
<img class="profile" src="https://www.rawpixel.com/image/6482362/png-sticker-public-domain" alt="multiple authors icon" />
</figure>
</header>
{% else %}
<header>
{{ render_author_gravatar(post, skip_gravatar) }}
</header>
{% endif %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I think this logic would be better placed in themes/vocabulary_theme/templates/macros/authors_gravatar.html
  2. Please include the image in the PR per previous feedback:

    please find an openly licensed or public domain image that can be included in this repository

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there! I was trying to figure out exactly how to include the image in the PR. I'm aware that the image has to be open source and secure but I'm not seeing a folder of a .yaml file to add the image to make it available locally (on github). Could you please indicate to me how I could go about doing this?

Also, I want to ensure that the image will be available indefinitely if needed without any interruptions, so I would like to not have to use the direct link.

Thank you in advance!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add the file to the content/ directory

Adding a file to a repository - GitHub Docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Improve multi-author support: multiple gravatar images
2 participants