-
-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve multi-author support with specific image for multiple authors #768
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you! there are a few requested changes
content/blog/entries/2023-04-26-umsi-how-many-mona-lisas/contents.lr
Outdated
Show resolved
Hide resolved
content/blog/entries/2023-04-26-umsi-how-many-mona-lisas/contents.lr
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you! there are a few requested changes
{% if post.author|length >= 2 %} | ||
|
||
<header> | ||
<figure class="image blog-image"> | ||
<img class="profile" src="https://www.rawpixel.com/image/6482362/png-sticker-public-domain" alt="multiple authors icon" /> | ||
</figure> | ||
</header> | ||
{% else %} | ||
<header> | ||
{{ render_author_gravatar(post, skip_gravatar) }} | ||
</header> | ||
{% endif %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I think this logic would be better placed in
themes/vocabulary_theme/templates/macros/authors_gravatar.html
- Please include the image in the PR per previous feedback:
please find an openly licensed or public domain image that can be included in this repository
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there! I was trying to figure out exactly how to include the image in the PR. I'm aware that the image has to be open source and secure but I'm not seeing a folder of a .yaml file to add the image to make it available locally (on github). Could you please indicate to me how I could go about doing this?
Also, I want to ensure that the image will be available indefinitely if needed without any interruptions, so I would like to not have to use the direct link.
Thank you in advance!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can add the file to the content/
directory
Fixes
Description
This PR adjusts the macro of files
authors_gravatar.html
andposts.html
so, whenever a post has multiple authors an image that is chosen to represent multiple authors instead. The gravatar for all other single author posts remains the same (according to their email addresses)Technical details
If
statements that takes the length ofpost.author
and checks whether the number of authors is above or equal to 1Screenshots
Before:
After:
Checklist
Update index.md
).main
ormaster
).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin