-
-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve multi-author support PR #778
Conversation
Your branch is up to date with 'origin/main'. Changes to be committed: new file: content/multiple-authors.Identifier new file: content/multiple-authors.jpg modified: themes/vocabulary_theme/templates/macros/posts.html
Your branch is up to date with 'origin/main'. Changes to be committed: modified: themes/vocabulary_theme/templates/macros/posts.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're very close! just a couple of requested changes
Changes to be committed: deleted: content/multiple-authors.Identifier modified: themes/vocabulary_theme/templates/macros/posts.html
Hi there! Thank you for helping me numerous times to fix my PR. I hope I don't cause you anymore trouble. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good work!
Fixes
Description
This PR adjusts the macro of files
authors_gravatar.html
andposts.html
so, whenever a post has multiple authors an image that is chosen to represent multiple authors instead. The gravatar for all other single author posts remains the same (according to their email addresses)It also resolves issues with previous PR #768 that I mistakenly closed (my deepest apologies)
Technical details
If
statements that takes the length ofpost.author
and checks whether the number of authors is above or equal to 1themes/vocabulary_theme/templates/macros/authors_gravatar.html
is something I plan to take on as a larger project as in order to implement it, I will need to change the logic of multiple other files that are outdated and contradictory (with your permission)Screenshots
Before:

After:

Checklist
Update index.md
).main
ormaster
).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin