Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve multi-author support PR #778

Merged
merged 4 commits into from
Apr 16, 2024
Merged

Conversation

Kirsty21
Copy link
Contributor

@Kirsty21 Kirsty21 commented Apr 13, 2024

Fixes

Description

This PR adjusts the macro of files authors_gravatar.html and posts.html so, whenever a post has multiple authors an image that is chosen to represent multiple authors instead. The gravatar for all other single author posts remains the same (according to their email addresses)

It also resolves issues with previous PR #768 that I mistakenly closed (my deepest apologies)

Technical details

  • If statements that takes the length of post.author and checks whether the number of authors is above or equal to 1
  • Also, in reference to your previous comment on PR Improve multi-author support with specific image for multiple authors #768 , placing this logic in the themes/vocabulary_theme/templates/macros/authors_gravatar.html is something I plan to take on as a larger project as in order to implement it, I will need to change the logic of multiple other files that are outdated and contradictory (with your permission)
  • However, if not, this can be a permanent fix

Screenshots

Before:
image

After:
image

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Your branch is up to date with 'origin/main'.

Changes to be committed:
	new file:   content/multiple-authors.Identifier
	new file:   content/multiple-authors.jpg
	modified:   themes/vocabulary_theme/templates/macros/posts.html
Your branch is up to date with 'origin/main'.

Changes to be committed:
	modified:   themes/vocabulary_theme/templates/macros/posts.html
@Kirsty21 Kirsty21 requested review from a team as code owners April 13, 2024 01:35
@Kirsty21 Kirsty21 requested review from TimidRobot, Shafiya-Heena and akmadian and removed request for a team April 13, 2024 01:35
Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're very close! just a couple of requested changes

Changes to be committed:
	deleted:    content/multiple-authors.Identifier
	modified:   themes/vocabulary_theme/templates/macros/posts.html
@Kirsty21 Kirsty21 requested a review from TimidRobot April 16, 2024 20:38
@Kirsty21
Copy link
Contributor Author

you're very close! just a couple of requested changes

Hi there! Thank you for helping me numerous times to fix my PR. I hope I don't cause you anymore trouble.

@TimidRobot TimidRobot self-assigned this Apr 16, 2024
Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work!

@TimidRobot TimidRobot merged commit 3953177 into creativecommons:main Apr 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Improve multi-author support: multiple gravatar images
2 participants