Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed featured class to remove blog highlight #927

Conversation

Queen-codes
Copy link
Contributor

Fixes

Description

this pr addresses the issue of author images being large and removes the featured class to allow all posts be equal grids.

Screenshots

127 0 0 1_5000_blog_entries_

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Queen-codes Queen-codes requested review from a team as code owners February 19, 2025 06:46
@Queen-codes Queen-codes requested review from TimidRobot, Shafiya-Heena and Dhruvi16 and removed request for a team February 19, 2025 06:46
@possumbilities possumbilities requested review from possumbilities and removed request for a team February 21, 2025 17:04
Copy link
Contributor

@possumbilities possumbilities left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an improvement, so approving!

But also, we should reconsider how we are displaying the author photos. In the way that .posts are handled in Vocabulary the image is supposed to be content directly relevant to the .post itself. But the author img is meta information about the author, and we need to find a way to treat it better within the context of the page semantics. Vocabulary, by intention does not include author photos at all, but the Open Source site does within its content model, and its a tension that needs resolution either within the Open Source site, Vocabulary, or both.

I think its worth creating an Issue to explore the semantics and use-cases for the author photos in .posts listings on the Open Source site.

@possumbilities possumbilities merged commit a3ca6a5 into creativecommons:vocab-refresh Feb 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants