Skip to content

Commit 52c7f48

Browse files
committed
remove DOM-validation
it checks agains an external DTD that will ratelimit too many requests. LoadHTML() itself already does everything we need
1 parent aeeed40 commit 52c7f48

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

vendor/erusev/parsedown-extra/ParsedownExtra.php

+6-5
Original file line numberDiff line numberDiff line change
@@ -628,11 +628,12 @@ protected function processTag($elementMarkup) # recursive
628628
$elementMarkup = mb_convert_encoding($elementMarkup, 'HTML-ENTITIES', 'UTF-8');
629629

630630
# http://stackoverflow.com/q/4879946/200145
631-
$DOMDocument->loadHTML($elementMarkup);
632-
633-
if (!$DOMDocument->validate()) {
634-
$errormessage = 'could not parse html<br>';
635-
$errors = libxml_get_errors();
631+
$DOMDocument->loadHTML($elementMarkup, LIBXML_DTDATTR | LIBXML_NONET);
632+
633+
$errors = libxml_get_errors();
634+
if ($errors)
635+
{
636+
$errormessage = "";
636637
foreach ($errors as $error) {
637638
$errormessage .= $error->message;
638639
$errormessage .= '<br>';

0 commit comments

Comments
 (0)