Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logstream-leader chart services overly opinionated #213

Open
PrymalInstynct opened this issue Jan 25, 2025 · 0 comments
Open

logstream-leader chart services overly opinionated #213

PrymalInstynct opened this issue Jan 25, 2025 · 0 comments

Comments

@PrymalInstynct
Copy link

PrymalInstynct commented Jan 25, 2025

It is my belief that the helm chart default values and the way that those values are converted into manifests are far too opinionated.

  1. The Ingress value forces the use of a NodePort service if you enable it, and it shuts off any configuration turning on the leadercomm port
  2. if you want your externalType to be Loadbalancer for the Leadercomm port it prevents you from using an ingress on the API port.

See my solution below to "overwrite" the opinionated config to end up in a place that worked.

I would love to see the ingress and service manifest templates in the chart updated to support a wider range of options.

          service:
            internalType: ClusterIP
            externalType: LoadBalancer
            ports:
              - name: api
                port: 9000
                protocol: TCP
                external: false
              - name: leadercomm
                port: 4200
                protocol: TCP
                external: true
          extraObjects:
            - apiVersion: networking.k8s.io/v1
              kind: Ingress
              metadata:
                name: cribl-leader
              spec:
                ingressClassName: nginx
                rules:
                - host: cribl-leader.local.domain
                  http:
                    paths:
                    - path: /
                      pathType: Prefix
                      backend:
                        service:
                          name: cribl-leader-internal
                          port:
                            number: 9000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant